Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

ui: build and release tabs tables view #2852

Merged
merged 5 commits into from
Jan 10, 2022
Merged

ui: build and release tabs tables view #2852

merged 5 commits into from
Jan 10, 2022

Conversation

sabrinako
Copy link
Contributor

@sabrinako sabrinako commented Dec 17, 2021 •
edited
Loading

TODOs

  • Update UIs
    • Add table view
    • Update AppItem row components
  • Add new tests
  • Update where the link is located on the table row

Remaining TODOs for the future

Notes

  • Flight icons currently does not have animated icons, so the loading icon for when a build/release is in progress is currently the delay icon and will be updated when the correct icon is available

How to test

  1. Pull down branch git checkout ui/build-release-tables
  2. yarn start to test with Mirage data, or start up Waypoint server and ember serve local
  3. Check the builds and releases table views.

Screenshots

Empty State

Screen Shot 2021-12-23 at 2 23 53 PM

Screen Shot 2021-12-23 at 2 23 59 PM

Build Table

Screen Shot 2021-12-23 at 2 27 32 PM

Release Table

Screen Shot 2021-12-23 at 2 27 24 PM

@sabrinako sabrinako added the ui label Dec 17, 2021
@sabrinako sabrinako added this to the 0.7.0 milestone Dec 17, 2021
@sabrinako sabrinako linked an issue Dec 17, 2021 that may be closed by this pull request
ui: update ui/ux of build and release list pages to tables #2774
Closed
@sabrinako sabrinako self-assigned this Dec 17, 2021
@github-actions
Copy link

github-actions bot commented Dec 17, 2021 •
edited
Loading

Ember Asset Size action

As of 11c941e

Files that got Bigger 🚨:

File raw gzip
vendor.js +5.86 kB +1.2 kB
waypoint.js +12.7 kB +2.35 kB
vendor.css +427 B +110 B
waypoint.css +861 B +108 B

@sabrinako sabrinako changed the title ui: build and release tabs tables view ui: (WIP) build and release tabs tables view Dec 17, 2021
@sabrinako sabrinako marked this pull request as ready for review January 3, 2022 20:16
@sabrinako sabrinako changed the title ui: (WIP) build and release tabs tables view ui: Build and release tabs tables view Jan 3, 2022
@sabrinako sabrinako changed the title ui: Build and release tabs tables view ui: build and release tabs tables view Jan 3, 2022
@sabrinako sabrinako requested review from almonk and a team January 3, 2022 20:16
@sabrinako sabrinako mentioned this pull request Jan 6, 2022
Closed
13 tasks
gregone
gregone approved these changes Jan 10, 2022
View reviewed changes
Copy link
Contributor

@gregone gregone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sabrinako sabrinako merged commit 52b404c into main Jan 10, 2022
@sabrinako sabrinako deleted the ui/build-release-tables branch January 10, 2022 15:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@almonk almonk almonk approved these changes

@gregone gregone gregone approved these changes

Assignees

@sabrinako sabrinako

Labels
ui
Projects
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.

ui: update ui/ux of build and release list pages to tables
3 participants
@sabrinako @almonk @gregone