Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct location annotation for parenthesized expressions #739

Merged
merged 2 commits into from
Oct 29, 2020
Merged

Correct location annotation for parenthesized expressions #739

merged 2 commits into from
Oct 29, 2020

Commits on Oct 29, 2020

  1. Correct location annotation for parenthesized expressions 

    At the moment parentheses are not included in the location annotation
for nix expressions. This changes the code to include any parentheses in
the SrcSpan of the underlying expression. Information which is difficult
to recover otherwise.
    @expipiplus1
    expipiplus1 committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    cbe995c View commit details
    Browse the repository at this point in the history

  2. Restrict type of parens and brackets to prevent negative use of NExprLoc 

    it is not generally appropriate to have higher-order parsers operate on
annotated locations as they are liable to perform changes to the parser which
are not captured in the annotation.

See haskell-nix#739 and
haskell-nix#744 for examples.
    @expipiplus1
    expipiplus1 committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    b00c6fa View commit details
    Browse the repository at this point in the history