Importing Extra.Cipher is not necessary anymore #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Much appreciated change, thanks. But surely incompatible, so next release will be 2.1 or 2.1.0, correct? |
|
I'm not sure that this is an incompatible change. |
|
Hm. Technically it is a change in semantics. You are arguing that since the old default is not only trivial but actually useless, nobody is relying on it. That may well be true, but it is not a certainty, so I'd rather err on the side of caution. Anyway, it's your decision to make. |
|
Merged. |
|
ありがとうございます |
|
どういたしまして。 |
bmillwood
added a commit
to bmillwood/req
that referenced
this pull request
Sep 21, 2024
On versions of tls pre-2.0.6, the default `Supported` had an empty list of `supportedCiphers`. Per discussion on [their issue][1], it seems like everyone was overriding it to `ciphersuite_default` anyway, hence the change at version 2.0.6 to make that default. But we're not doing that here! Luckily, the [default for `TLSSettings`][2] does do that override, so we can use that to get the right behaviour regardless of tls version. [1]: haskell-tls/hs-tls#471 [2]: https://hackage.haskell.org/package/crypton-connection-0.4.0/docs/src/Network.Connection.Types.html#line-86
mrkkrp
pushed a commit
to mrkkrp/req
that referenced
this pull request
Sep 29, 2024
On versions of tls pre-2.0.6, the default `Supported` had an empty list of `supportedCiphers`. Per discussion on [their issue][1], it seems like everyone was overriding it to `ciphersuite_default` anyway, hence the change at version 2.0.6 to make that default. But we're not doing that here! Luckily, the [default for `TLSSettings`][2] does do that override, so we can use that to get the right behaviour regardless of tls version. [1]: haskell-tls/hs-tls#471 [2]: https://hackage.haskell.org/package/crypton-connection-0.4.0/docs/src/Network.Connection.Types.html#line-86
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Jan 30, 2025
# Change log for "tls" ## Version 2.1.7 * Introducing `Limit` parameter. * Implementing "Record Size Limit Extension for TLS" (RFC8449). Set `limitRecordSize` use it. * Implementing "TLS Certificate Compression" (RFC 8879). This feature is automatically used if the peer supports it. * More tests with `tlsfuzzer` especially for client authentication and 0-RTT. * Implementing a utility funcation, `validateClientCertificate`, for client authentication. * Bug fix for echo back logic of Cookie extension. * More pretty show for the internal `Handshake` structure for debugging. ## Version 2.1.6 * Testing with "tlsfuzzer" again. Now don't send an alert agaist to peer's alert. Double locking (aka self dead-lock) is fixed. Sending an alert for known-but-cannot-parse extensions. Other corner cases are also fixed. * `tls-client -d` and `tls-server -d` pretty-prints `Handshake`. ## Version 2.1.5 * Removing the dependency on the async package. * Restore a few DHE_RSA ciphers. [#493](haskell-tls/hs-tls#493) ## Version 2.1.4 * Exporting defaultValidationCache. ## Version 2.1.3 * Remove `data-default` version constraint. [#492](haskell-tls/hs-tls#492) * Exporting default variables. [#448](haskell-tls/hs-tls#488) ## Version 2.1.2 * Using data-default instead of data-default-class. ## Version 2.1.1 * `bye` directly calls `timeout recvHS13`, not spawning a thread for `timeout recvHS13`. So, `bye` can receive an exception if thrown. ## Version 2.1.0 * Breaking change: stop exporting constructors to maintain future compatibilities. Field names are still exported, and values can be updated with them using record syntax. Use `def` and `noSessionManager` as initial values. * `onServerFinished` is added to `ClientHooks`. * `clientWantSessionResumeList` is added to `ClientParams` to support multiple tickets for TLS 1.3. ## Version 2.0.6 * Setting `supportedCiphers` in `defaultSupported` to `ciphersuite_default`. So, users don't have to override this value anymore by exporting `Network.TLS.Extra.Cipher`. [#471](haskell-tls/hs-tls#471) * `ciphersuite_default` is the same as `ciphersuite_strong`. So, the duplicated definition is removed. * Add missing modules for util/tls-client and util/tls-server.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See kazu-yamamoto/crypton-connection#3