Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data default cleanup #492

Merged
merged 2 commits into from
Nov 3, 2024
Merged

Conversation

Vlix
Copy link
Contributor

@Vlix Vlix commented Nov 2, 2024

If you could also update the constraints of the following package versions, that'd be great:

  • tls-2.1.2: remove data-default version constraint
  • tls-session-manager: up auto-update lower version bound to 0.2.2

Vlix added 2 commits November 2, 2024 16:05
…ly ever had one class and one method.

Default instances from 'data-default' aren't used, so the version doesn't matter.

I've also restricted the imports from 'Data.Default' for clarity's sake.
Copy link
Collaborator

@kazu-yamamoto kazu-yamamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kazu-yamamoto kazu-yamamoto merged commit 5211e00 into haskell-tls:main Nov 3, 2024
@kazu-yamamoto
Copy link
Collaborator

Merged. Thanks!

@Bodigrim
Copy link

Bodigrim commented Nov 7, 2024

As a Hackage trustee, I also revised bounds on data-default-class in tls-2.0.6, which helps users who are stuck with tls < 2.1. I hope it's alright.

@kazu-yamamoto
Copy link
Collaborator

@Bodigrim Thanks!

@Vlix Vlix deleted the data-default-cleanup branch November 8, 2024 07:39
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Jan 30, 2025
# Change log for "tls"

## Version 2.1.7

* Introducing `Limit` parameter.
* Implementing "Record Size Limit Extension for TLS" (RFC8449).
  Set `limitRecordSize` use it.
* Implementing "TLS Certificate Compression" (RFC 8879).
  This feature is automatically used if the peer supports it.
* More tests with `tlsfuzzer` especially for client authentication
  and 0-RTT.
* Implementing a utility funcation, `validateClientCertificate`, for
  client authentication.
* Bug fix for echo back logic of Cookie extension.
* More pretty show for the internal `Handshake` structure for debugging.

## Version 2.1.6

* Testing with "tlsfuzzer" again. Now don't send an alert agaist to
  peer's alert. Double locking (aka self dead-lock) is fixed. Sending
  an alert for known-but-cannot-parse extensions. Other corner cases
  are also fixed.
* `tls-client -d` and `tls-server -d` pretty-prints `Handshake`.

## Version 2.1.5

* Removing the dependency on the async package.
* Restore a few DHE_RSA ciphers.
  [#493](haskell-tls/hs-tls#493)

## Version 2.1.4

* Exporting defaultValidationCache.

## Version 2.1.3

* Remove `data-default` version constraint.
  [#492](haskell-tls/hs-tls#492)
* Exporting default variables.
  [#448](haskell-tls/hs-tls#488)

## Version 2.1.2

* Using data-default instead of data-default-class.

## Version 2.1.1

* `bye` directly calls `timeout recvHS13`, not spawning a thread for
  `timeout recvHS13`. So, `bye` can receive an exception if thrown.

## Version 2.1.0

* Breaking change: stop exporting constructors to maintain future
  compatibilities. Field names are still exported, and values can be updated
  with them using record syntax. Use `def` and `noSessionManager` as initial
  values.
* `onServerFinished` is added to `ClientHooks`.
* `clientWantSessionResumeList` is added to `ClientParams` to support
  multiple tickets for TLS 1.3.

## Version 2.0.6

* Setting `supportedCiphers` in `defaultSupported` to `ciphersuite_default`.
  So, users don't have to override this value anymore by exporting
  `Network.TLS.Extra.Cipher`.
  [#471](haskell-tls/hs-tls#471)
* `ciphersuite_default` is the same as `ciphersuite_strong`.
  So, the duplicated definition is removed.
* Add missing modules for util/tls-client and util/tls-server.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants