Improve benchmarks for small Builders #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Do not measure the overhead of allocating destination chunks * Add several more benchmarks for P.cstring and P.cstringUtf8
Bodigrim
approved these changes
Jun 5, 2024
Bodigrim
pushed a commit
that referenced
this pull request
Oct 9, 2024
* Improve benchmarks for small Builders * Do not measure the overhead of allocating destination chunks * Add several more benchmarks for P.cstring and P.cstringUtf8 * More benchmark fiddling * Update "since" markers for new NFData instances
Bodigrim
pushed a commit
that referenced
this pull request
Oct 15, 2024
* Improve benchmarks for small Builders * Do not measure the overhead of allocating destination chunks * Add several more benchmarks for P.cstring and P.cstringUtf8 * More benchmark fiddling * Update "since" markers for new NFData instances
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...separated out from #569. The main improvement is that this separates the buffer allocation cost (which is similar for all
Builders) from the actual write/encoding cost.