Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changelog for bytestring-0.12.2.0 #696

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Bodigrim
Copy link
Contributor

No description provided.

@Bodigrim Bodigrim added this to the 0.12.2.0 milestone Oct 15, 2024
@Bodigrim Bodigrim requested a review from clyring October 15, 2024 22:48
@clyring
Copy link
Member

clyring commented Oct 20, 2024

The existing entries and organization look good to me.

Also, we are still only working around #665 in a Hackage revision. We should fix it properly (or at least merge the contents of the Hackage revision into the source repo) before cutting a release. I can prepare a MR for this tomorrow, if you don't beat me to it.

@Bodigrim
Copy link
Contributor Author

Technically this is a breaking change as-is, since the use of packUptoLenBytes means that the input list will be truncated if the list is longer than the size hint suggests.

Yeah, maybe it's better to revert the change to instance IsList StrictByteString.

We should fix it properly (or at least merge the contents of the Hackage revision into the source repo)

Let's make our lives easier and just backport the revision.


Feel free to push any corrections into this branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants