Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cabal new-haddock fails for build-type:configure #5503

Closed
hvr opened this issue Aug 6, 2018 · 2 comments · Fixed by #5573
Closed

cabal new-haddock fails for build-type:configure #5503

hvr opened this issue Aug 6, 2018 · 2 comments · Fixed by #5573
Assignees
@chshersh @vrom911
Labels
cabal-install: cmd/haddock cabal-install: nix-local-build priority: high 🔥 type: bug
Milestone
2.4

Comments

@hvr
Copy link
Member

hvr commented Aug 6, 2018

Reproduction:

$ cabal get network-2.7.0.2 && cd network-2.7.0.2/
$ cabal new-haddock -w ghc-8.4.3 -v
$ cabal new-haddock -w ghc-8.4.3 
Build profile: -w ghc-8.4.3 -O1
In order, the following will be built (use -v for more details):
 - network-2.7.0.2 (first run)
cabal: Unrecognised flags: lib:network
Warning: Failed to build documentation for network-2.7.0.2.

using -v reveals:

...
configure: creating ./config.status
config.status: creating network.buildinfo
config.status: creating include/HsNetworkConfig.h
configure: WARNING: unrecognized options: --with-compiler
Reading parameters from
/tmp/network-2.7.0.2/dist-newstyle/build/x86_64-linux/ghc-8.4.3/network-2.7.0.2/build/network.buildinfo
whenReRegister: nothing to register
Using self-exec internal setup method with build-type Configure and args:
["act-as-setup","--build-type=Configure","--","haddock","--verbose=2","--builddir=/tmp/network-2.7.0.2/dist-newstyle/build/x86_64-linux/ghc-8.4.3/network-2.7.0.2","lib:network"]
/stuff/dot-cabal/bin/cabal act-as-setup --build-type=Configure -- haddock
--verbose=2
--builddir=/tmp/network-2.7.0.2/dist-newstyle/build/x86_64-linux/ghc-8.4.3/network-2.7.0.2
lib:network
cabal: Unrecognised flags: lib:network
Warning: Failed to build documentation for network-2.7.0.2-inplace.
@hvr hvr added this to the 2.4 milestone Aug 6, 2018
@hvr
Copy link
Member Author

hvr commented Aug 6, 2018 •
edited
Loading

This is related to #5261 which fixed the same symptom for build-type: Custom; however, the issue at hand is about build-type: Configure!

@hvr
Copy link
Member Author

hvr commented Aug 6, 2018

@alexbiehl suggests the culprit to be

missing the logic from

chshersh pushed a commit that referenced this issue Sep 7, 2018
[#5503] Add filterHaddockFlags for new-haddock
d7f7759
hvr added a commit to hvr/cabal that referenced this issue Sep 8, 2018
@hvr
Allow arguments to be passed to Setup.hs haddock for `build-type:co…
b759611 
…nfigure`

In the course of 4466310 (see haskell#5526) the
`Setup.hs haddock` CLI was extended to allow component ids to be passed
as positional arguments. However, `autoconfUserHooks` which is used in
case of `build-type: Configure` wasn't updated accordingly, and consequently
this caused `new-haddock` to break for packages using `Configure`.

Fixes haskell#5503
hvr added a commit to hvr/cabal that referenced this issue Sep 8, 2018
@hvr
Allow arguments to be passed to Setup.hs haddock for `build-type:co…
86dabda 
…nfigure`

In the course of 4466310 (see haskell#5526) the
`Setup.hs haddock` CLI was extended to allow component ids to be passed
as positional arguments. However, `autoconfUserHooks` which is used in
case of `build-type: Configure` wasn't updated accordingly, and consequently
this caused `new-haddock` to break for packages using `Configure`.

cc @alexbiehl

Fixes haskell#5503
@hvr hvr mentioned this issue Sep 8, 2018
Merged
hvr added a commit that referenced this issue Sep 8, 2018
@hvr
Allow arguments to be passed to Setup.hs haddock for `build-type:co…
3d2b9d0 
…nfigure`

In the course of 4466310 (see #5526) the
`Setup.hs haddock` CLI was extended to allow component ids to be passed
as positional arguments. However, `autoconfUserHooks` which is used in
case of `build-type: Configure` wasn't updated accordingly, and consequently
this caused `new-haddock` to break for packages using `Configure`.

cc @alexbiehl

Fixes #5503

(cherry picked from commit 86dabda)
hvr added a commit that referenced this issue Sep 8, 2018
@hvr
Changelog entry for #5503 / #5573
6d694b8
@hvr hvr closed this as completed in #5573 Sep 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chshersh chshersh

@vrom911 vrom911

Labels
cabal-install: cmd/haddock cabal-install: nix-local-build priority: high 🔥 type: bug
Projects
None yet
Milestone
2.4
Development

Successfully merging a pull request may close this issue.

Allow arguments to be passed to Setup.hs haddock for build-type:configure hvr/cabal
3 participants
@hvr @chshersh @vrom911