SetupWrapper: Filtering for Setup arguments

[alexbiehl]

Addresses #5260.

Since f3cacff we pass the components to generate documentation for to Setup with new-haddock. Older Cabals do not like this as reported by Herbert in #5260. This patch installs an argument filter mechanism just like the one for flag filtering. We now never pass extra arguments to Setup haddock for older Cabals.

---

Please include the following checklist in your PR:

• Patches conform to the coding conventions.
• Any changes that could be relevant to users have been recorded in the changelog.
• The documentation has been updated, if necessary.
• If the change is docs-only, [ci skip] is used to avoid triggering the build bots.

Please also shortly describe how you tested your change. Bonus points for added tests!

[alexbiehl]

@harpocrates I think #5236 needs proper version gating for --haddock-quickjump on older Cabal's too! (@hvr, right?)

[harpocrates]

Doesn't this PR solve the problem for quickjump too (via filterHaddockFlags)? Assuming the quickjump PR makes it into 2.3 too, --quickjump should also only be let through on Cabal >=2.3.0, right?

[alexbiehl]

Correct

[23Skidoo]

Looks okay to me. Maybe we should think about making enabled components more explicit in the setup wrapper's type signature - using extraArgs for that is a bit stringly-typed and ambiguous.

[harpocrates]

Is there anything blocking this from being merged?

[phadej]

@alexbiehl this works for me. I used master + grayjays patch to fix one issue, and this patch fixed haddock. see jobs in haskell-servant/servant#961

[23Skidoo]

Rebased against master and force-pushed, let's see if it passes now.

[23Skidoo]

Code looks good, I'll merge this once CI is green.

[23Skidoo]

Merged, thanks! Sorry for the long wait.