Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

".." added by Distribution.Backpack.DescribeUnitId.setupMessage', not full stop or ellipsis? #8928

Closed
mpilgrem opened this issue Apr 30, 2023 · 2 comments · Fixed by #8929
Closed

Comments

@mpilgrem
Copy link
Collaborator

A very minor UI point: the ".." added to the end of setup messages by setupMessage' is neither a full stop (".") nor an ellipsis ("...") - see the where statement in the code extract further below. Is that intentional, or a bug? If a bug, I'll raise a pull request to change it to an ellipsis. It results in output like:

Preprocessing library for foo-0.1.0.0..
Building library for foo-0.1.0.0..
-- | Print a Setup message stating (1) what operation we are doing,
-- for (2) which component (with enough details to uniquely identify
-- the build in question.)
--
...
setupMessage' verbosity msg pkgid cname mb_insts = withFrozenCallStack $ do
    noticeDoc verbosity $
      case mb_insts of
...
        _ ->
          msg_doc <+> for_doc

  where
    msg_doc = text msg <+> text (showComponentName cname)
    for_doc = text "for" <+> pretty pkgid <<>> text ".."
@ulysses4ever
Copy link
Collaborator

Changed from ellipsis to .. here: bc9d5ad

I think it's pretty safe to assume that it's a typo, and a PR fixing it would be very welcome.

@mpilgrem
Copy link
Collaborator Author

@ulysses4ever, thanks - pull request raised.

@ulysses4ever ulysses4ever linked a pull request Apr 30, 2023 that will close this issue
4 tasks
mpilgrem added a commit that referenced this issue Apr 30, 2023
Also adds ellipsis to lines in *.out files.
mpilgrem added a commit that referenced this issue Apr 30, 2023
Also adds ellipsis to lines in *.out files.
mpilgrem added a commit that referenced this issue Jun 2, 2023
Also adds ellipsis to lines in *.out files.
mpilgrem added a commit that referenced this issue Jun 2, 2023
Also adds ellipsis to lines in *.out files.
mpilgrem added a commit that referenced this issue Jun 2, 2023
Fix #8928 Conclude setup messages with an ellipsis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants