Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #8928 Conclude setup messages with an ellipsis #8929

Merged
merged 1 commit into from
Jun 2, 2023
Merged

Conversation

mpilgrem
Copy link
Collaborator

Bonus points for added automated tests!

@ulysses4ever
Copy link
Collaborator

Thank you!

I'm seeing a good bunch of reference tests results holding the .., so you will have to run the test suite with --accept locally to update them. Details on running the test should be in https://github.com/haskell/cabal/blob/master/cabal-testsuite/README.md Or you could sed...

@mpilgrem
Copy link
Collaborator Author

mpilgrem commented May 1, 2023

@ulysses4ever, I took the search and replace route. After a couple of false starts, the checks now pass.

Copy link
Collaborator

@ulysses4ever ulysses4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Terrific!

@Kleidukos
Copy link
Member

@mpilgrem Hi, do you need help with rebasing this PR? I can offer my help.

@mpilgrem
Copy link
Collaborator Author

mpilgrem commented Jun 2, 2023

@Kleidukos, I had not spotted that. I'll look at it over the coming weekend and let you know.

@ulysses4ever
Copy link
Collaborator

@mpilgrem thanks a lot for updating the PR and sorry it took so long to get all the approvals! There is a couple tests that have been added in the meantime and they have to be fixed, see the CI but I think the relevant bit is:

UNEXPECTED FAIL: 
PackageTests/NewBuild/CmdBuild/ScriptBuildRepl/cabal.test.hs 
PackageTests/MultiRepl/EnabledClosure/cabal.test.hs 
PackageTests/MultiRepl/EnabledSucc/cabal.test.hs

Also adds ellipsis to lines in *.out files.
@mpilgrem mpilgrem merged commit 6c11a04 into master Jun 2, 2023
@mpilgrem mpilgrem deleted the fix8928 branch June 2, 2023 22:17
@ulysses4ever
Copy link
Collaborator

@mpilgrem thanks a lot for attending to it! One thing for the future: normally, we don't manually merge PRs but rather employ a merge bot. So, when you get 2 approvals and a green CI, you're expected to put one of the two labels: merge-me or squash+merge, and the bot will merge it after a two-day delay (a precautionary measure).

@mpilgrem
Copy link
Collaborator Author

mpilgrem commented Jun 3, 2023

@ulysses4ever, sorry - I did not appreciate that (about merging). EDIT: I should have read the CONTRIBUTING.md more carefully.

@ulysses4ever ulysses4ever mentioned this pull request Oct 27, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

".." added by Distribution.Backpack.DescribeUnitId.setupMessage', not full stop or ellipsis?
4 participants