Disable arch-native flag when building releases that we distribute (backport #10142) #10144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
ulysses4ever
approved these changes
Jun 24, 2024
geekosaur
approved these changes
Jun 24, 2024
|
Uh, why does this want two approvals? It says it's a backport. |
|
You mean GitHub? Dunno. Mergify seems to be ok (https://github.com/haskell/cabal/pull/10144/checks?check_run_id=26615884274, the backport/squash rule). |
|
Argh, Windows build glitch. |
mergify
bot
added
the
merge delay passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't want to accidentally create binaries that contain CPU instructions only available in some machines. Hashable has this flag that enables the usage of
-march=nativefor its FFI C code, so we have to disable it explicitly.The
cabal.validate.projectfile is also concerned because we use it to build thecabal-headbinary that we distribute.This is an automatic backport of pull request #10142 done by Mergify.