Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable arch-native flag when building releases that we distribute #10142

Merged
merged 3 commits into from
Jun 24, 2024
Merged

Disable arch-native flag when building releases that we distribute #10142

merged 3 commits into from
Jun 24, 2024

Conversation

Kleidukos
Copy link
Member

@Kleidukos Kleidukos commented Jun 24, 2024 •
edited
Loading

We don't want to accidentally create binaries that contain CPU instructions only available in some machines. Hashable has this flag that enables the usage of -march=native for its FFI C code, so we have to disable it explicitly.

The cabal.validate.project file is also concerned because we use it to build the cabal-head binary that we distribute.

mpickering
mpickering reviewed Jun 24, 2024
View reviewed changes
cabal.release.project Outdated Show resolved Hide resolved
@Kleidukos Kleidukos force-pushed the disable-march-native-flag branch from 031971c to 4244fb5 Compare June 24, 2024 12:51
@ulysses4ever
Copy link
Collaborator

We probably need to fast-track this to not hold back the release, don't we?

@Kleidukos
Copy link
Member Author

@ulysses4ever Probably yes

@geekosaur
Copy link
Collaborator

Seems likely, yes.

@ulysses4ever ulysses4ever added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Jun 24, 2024
@ulysses4ever ulysses4ever mentioned this pull request Jun 24, 2024
Closed
18 tasks
@Kleidukos Kleidukos added the squash+merge me Tell Mergify Bot to squash-merge label Jun 24, 2024
@mergify mergify bot merged commit 9bb4f58 into haskell:master Jun 24, 2024
52 checks passed
@ulysses4ever
Copy link
Collaborator

@mergify backport 3.12

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 24, 2024 •
edited
Loading

backport 3.12

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jun 24, 2024
@Kleidukos @mergify
Disable arch-native flag when building releases that we distribute (#…
2468b1d 
…10142)

* Disable arch-native flag when building releases that we distribute

* Use the constraints stanza

* Also disable the flag in cabal.validate.project

(cherry picked from commit 9bb4f58)
@mergify mergify bot mentioned this pull request Jun 24, 2024
Merged
@TerrorJack TerrorJack mentioned this pull request Jun 24, 2024
Closed
mergify bot added a commit that referenced this pull request Jun 24, 2024
@mergify @Kleidukos
Disable arch-native flag when building releases that we distribute (#…
357bbf0 
…10142) (#10144)

* Disable arch-native flag when building releases that we distribute

* Use the constraints stanza

* Also disable the flag in cabal.validate.project

(cherry picked from commit 9bb4f58)

Co-authored-by: Hécate <Kleidukos@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpickering mpickering mpickering left review comments

@ulysses4ever ulysses4ever ulysses4ever approved these changes

@geekosaur geekosaur geekosaur approved these changes

Assignees
No one assigned
Labels
merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days squash+merge me Tell Mergify Bot to squash-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Kleidukos @ulysses4ever @geekosaur @mpickering