hls-plugin-api: version bump

[Galagora]

The version on Hackage currently doesn't build. This prevents the current master from being built in Nixpkgs. @alanz, please upload the 0.4.0.1 tarball to Hackage.

--- Version on Hackage
+++ Master version
@@ -39,7 +39,7 @@

 commandAddSignature :: CommandFunction WorkspaceEdit
 commandAddSignature lf ide params
-    = executeAddSignatureCommand lf ide (ExecuteCommandParams "typesignature.add" (Just (List [toJSON params])) Nothing)
+    = commandHandler lf ide (ExecuteCommandParams "typesignature.add" (Just (List [toJSON params])) Nothing)

 -- ---------------------------------------------------------------------

[jneira]

But the actual ghcide released version (0.3.0) does not have commandHandler in https://github.com/haskell/ghcide/blob/v0.3.0/src/Development/IDE/Plugin/CodeAction.hs, but executeAddSignatureCommand.
Afaiu we should wait to the next ghcide release to upload this change to hackage.
So the nix build is not using ghcide from hackage but it does for hls-plugin-api?

[Galagora]

Nix uses the Ghcide submodule for haskell-language-server. See: https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/tools/haskell/haskell-language-server/hls-ghcide.nix and https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/haskell-modules/configuration-common.nix#L1485. So 3815d24 can't be built, because Nix uses hls-plugin-api from Hackage.

[jneira]

Aha, i am afraid that still we'll have to wait to a ghcide release or cabal get hls-plugin-api && cd hls-plugin-api && cabal build will fail, and the projects using hls-plugin-api directly from hackage will do too.
I am not a nix expert but, could the nix build use the hls-plugin-api from the hls repo instead from hackage? It will be make the build more robust

[jneira]

Well, i am afraid that the hackage version of hls-plugin-api cant be built standalone cause it relies in the ghcide fork that was used when it was uploaded. It fails to compile with the hackage version of ghcide 😟
That should not be like that, and i still think the next release should be done correctly, against a suitable released ghcide version.

[alanz]

The package was published in a rush to enable a munihac workshop. So the release admin was not very good, sorry, my fault.

[Galagora]

I agree; it's more robust to use the hls-plugin-api from this repo, rather than from Hackage.