-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable lexical binding in every source lisp file #827
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note, how emacs 24.5.2 fails to detect some bindings as used.. Pretty amazed by the fact. |
deepfire
force-pushed
the
lexically-yours
branch
from
August 22, 2015 15:06
446b95a
to
9ff69fa
Compare
@gracjan, there was one, yes, in |
Lets give this pull request 24h for other guys reading to chime in if they see anything wrong in here. |
gracjan
changed the title
Lexically yours -- #815
Enable lexical binding in every source lisp file
Aug 22, 2015
First line should be package declaration by Emacs packaging convention. So first line should be as below. ;;; ghc-core.el --- Syntax highlighting module for GHC Core -*- lexical-binding: t -*- Examples |
@gracjan, sure thing. |
deepfire
force-pushed
the
lexically-yours
branch
from
August 23, 2015 14:15
9ff69fa
to
fb3ab2f
Compare
deepfire
force-pushed
the
lexically-yours
branch
from
August 23, 2015 14:18
fb3ab2f
to
1d861d3
Compare
Done.
|
gracjan
added a commit
that referenced
this pull request
Aug 23, 2015
Enable lexical binding in every source lisp file
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #815.