Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix deploy script to upload github release assets #4103

Merged
merged 4 commits into from
Mar 25, 2020
Merged

ci: fix deploy script to upload github release assets #4103

merged 4 commits into from
Mar 25, 2020

Conversation

arvi3411301
Copy link
Member

@arvi3411301 arvi3411301 commented Mar 13, 2020 •
edited
Loading

Description

This PR fixes the issue with deploy script which fails with invalid number of arguments error with ghr.

Changelog

  • CHANGELOG.md is updated with user-facing content relevant to this PR.

Affected components

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System
  • Tests
  • Other (list it)

Solution and Design

  1. Create a draft PR.
  2. Upload CLI assets
  3. Upload cli-ext assets.

Steps to test and verify

Limitations, known bugs & workarounds

@arvi3411301 arvi3411301 added the c/build-system Related to the build-release system label Mar 13, 2020
@arvi3411301 arvi3411301 requested a review from shahidhk March 13, 2020 11:05
@hasura-bot
Copy link
Contributor

Review app for commit 636ec44 deployed to Heroku: https://hge-ci-pull-4103.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4103-636ec44c

@arvi3411301 arvi3411301 added this to the v1.2 milestone Mar 17, 2020
@hasura-bot
Copy link
Contributor

Review app for commit f20fed1 deployed to Heroku: https://hge-ci-pull-4103.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4103-f20fed1e

@shahidhk shahidhk changed the title fix deploy script to upload github release assets ci: fix deploy script to upload github release assets Mar 25, 2020
@shahidhk shahidhk merged commit 0a0dfd4 into hasura:master Mar 25, 2020
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-4103.herokuapp.com is deleted

@shahidhk shahidhk deleted the fix-ghr-deploy branch March 25, 2020 10:51
@hasura-bot
Copy link
Contributor

Review app for commit f742a6d deployed to Heroku: https://hge-ci-pull-4103.herokuapp.com
Docker image for server: hasura/graphql-engine:pull4103-f742a6de

anurag pushed a commit to anurag/graphql-engine that referenced this pull request Mar 26, 2020
@arvi3411301 @anurag
ci: fix deploy script to upload github release assets (hasura#4103)
e00e231
@Allymahmoud Allymahmoud mentioned this pull request Jun 27, 2023
Open
@Allymahmoud Allymahmoud mentioned this pull request Dec 6, 2023
Open
@ptakpatryk ptakpatryk mentioned this pull request Dec 6, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahidhk shahidhk shahidhk approved these changes

@marionschleifer marionschleifer Awaiting requested review from marionschleifer

Assignees

@shahidhk shahidhk

Labels
c/build-system Related to the build-release system
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.
3 participants
@arvi3411301 @hasura-bot @shahidhk