Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix deploy script to upload github release assets #4103

Merged
merged 4 commits into from
Mar 25, 2020
+19 −1
Merged

ci: fix deploy script to upload github release assets #4103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
636ec44
fix deploy script to upload github release assets
arvi3411301 Mar 13, 2020
97c74c8
Merge branch 'master' into fix-ghr-deploy
arvi3411301 Mar 25, 2020
f20fed1
update CHANGELOG.md
arvi3411301 Mar 25, 2020
f742a6d
Merge branch 'master' into fix-ghr-deploy
shahidhk Mar 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion .circleci/deploy.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,24 @@ draft_github_release() {
-r "$CIRCLE_PROJECT_REPONAME" \
-b "${RELEASE_BODY}" \
-draft \
"$CIRCLE_TAG" /build/_cli_output/binaries/ /build/_cli_ext_output/*.tar.gz /build/_cli_ext_output/*.zip
"$CIRCLE_TAG"
echo "uploading cli assets"
ghr -t "$GITHUB_TOKEN" \
-u "$CIRCLE_PROJECT_USERNAME" \
-r "$CIRCLE_PROJECT_REPONAME" \
-draft \
"$CIRCLE_TAG" /build/_cli_output/binaries/
echo "uploading cli-ext assets"
ghr -t "$GITHUB_TOKEN" \
-u "$CIRCLE_PROJECT_USERNAME" \
-r "$CIRCLE_PROJECT_REPONAME" \
-draft \
"$CIRCLE_TAG" /build/_cli_ext_output/*.tar.gz
ghr -t "$GITHUB_TOKEN" \
-u "$CIRCLE_PROJECT_USERNAME" \
-r "$CIRCLE_PROJECT_REPONAME" \
-draft \
"$CIRCLE_TAG" /build/_cli_ext_output/*.zip
}

configure_git() {
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@

### Other changes

- fix deploy script to upload github release assets
- cli: fix parse error returned on console api (close #4126)
- console and cli-ext: fix parsing of wrapped types in SDL
- cli: fix typo in cli example for squash (fix #4047) (#4049)
Expand Down