Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable HASURA_GRAPHQL_PG_CONN_LIFETIME by default with a default of 1… #6190

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jberryman
Copy link
Collaborator

@jberryman jberryman commented Nov 12, 2020

…20 sec

See: hasura/pg-client-hs#26

We're still experiencing segfaults in certain configurations from the
libpq shrinking approach. This should be very safe, but is also
inadequate in several ways:

  • negotiating a new connection is quite heavyweight compared to
    allocating a 1mb buffer
  • thundering herd issues (TODO maybe add some jitter here)
  • memory is not reclaimed promptly; there is no good default here.

Description

Changelog

  • CHANGELOG.md is updated with user-facing content relevant to this PR. If no changelog is required, then add the no-changelog-required label.

Affected components

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System
  • Tests
  • Other (list it)

Related Issues

Solution and Design

Steps to test and verify

Limitations, known bugs & workarounds

Server checklist

Catalog upgrade

Does this PR change Hasura Catalog version?

  • No
  • Yes
    • Updated docs with SQL for downgrading the catalog

Metadata

Does this PR add a new Metadata feature?

  • No
  • Yes
    • Does run_sql auto manages the new metadata through schema diffing?
      • Yes
      • Not required
    • Does run_sql auto manages the definitions of metadata on renaming?
      • Yes
      • Not required
    • Does export_metadata/replace_metadata supports the new metadata added?
      • Yes
      • Not required

GraphQL

  • No new GraphQL schema is generated
  • New GraphQL schema is being generated:
    • New types and typenames are correlated

Breaking changes

  • No Breaking changes

  • There are breaking changes:

    1. Metadata API

      Existing query types:

      • Modify args payload which is not backward compatible
      • Behavioural change of the API
      • Change in response JSON schema
      • Change in error code
    2. GraphQL API

      Schema Generation:

      • Change in any NamedType
      • Change in table field names

      Schema Resolve:-

      • Change in treatment of null value for any input fields
    3. Logging

      • Log JSON schema has changed
      • Log type names have changed

…00 sec

See: hasura/pg-client-hs#26

We're still experiencing segfaults in certain configurations from the
libpq shrinking approach. This should be very safe, but is also
inadequate in several ways:

- negotiating a new connection is quite heavyweight compared to
  allocating a 1mb buffer
- thundering herd issues (TODO maybe add some jitter here)
- memory is not reclaimed promptly; there is no good default here.
@jberryman jberryman force-pushed the default-HASURA_GRAPHQL_PG_CONN_LIFETIME branch from d4a1d49 to 13746b2 Compare November 16, 2020 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants