Enable HASURA_GRAPHQL_PG_CONN_LIFETIME by default with a default of 1… #6191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…20 sec See: hasura/pg-client-hs#26 We're still experiencing segfaults in certain configurations from the libpq shrinking approach. This should be very safe, but is also inadequate in several ways: - negotiating a new connection is quite heavyweight compared to allocating a 1mb buffer - thundering herd issues (TODO maybe add some jitter here) - memory is not reclaimed promptly; there is no good default here. # Conflicts: # CHANGELOG.md # server/cabal.project # server/src-lib/Hasura/Server/Init.hs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cherry-pick (with resolved conflicts) of #6190 for testing