Add not_none #7
Open
Add not_none #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
JelleZijlstra
commented
Jun 22, 2023
|
|
||
|
|
||
| def test(x: Any, y: str | None, z: str) -> None: | ||
| assert_type(not_none(x), Any) |
There was a problem hiding this comment.
Mypy fails on this one:
static_tests/test_not_none.py:10: error: Expression is of type <nothing>, not "Any" [assert-type]
Possibly fixable with overloads, let me try that
There was a problem hiding this comment.
OK, now pyright fails with something worse:
/home/runner/work/useful_types/useful_types/static_tests/test_not_none.py:10:17 - error: "assert_type" mismatch: expected "Any" but received "Never" (reportGeneralTypeIssues)
I think I prefer the version without overloads.
There was a problem hiding this comment.
I think might work with both if you reorder overloads?
There was a problem hiding this comment.
No, that way it doesn't narrow away the None at all, because None matches the first overload.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.