-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add not_none #7
Open
JelleZijlstra
wants to merge
10
commits into
hauntsaninja:main
Choose a base branch
from
JelleZijlstra:notnone
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add not_none #7
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
29dc811
Add not_none
JelleZijlstra 9dbb3e9
Update static_tests/test_not_none.py
JelleZijlstra dc7e7fd
Merge branch 'main' into notnone
hauntsaninja e96e0de
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 7f8e137
Merge branch 'main' into notnone
hauntsaninja 8e658dc
Merge branch 'main' into notnone
JelleZijlstra c42f4aa
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] cfd8e77
fix indent
JelleZijlstra 1bde161
try this way
JelleZijlstra 8d77448
try the other way
JelleZijlstra File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
from __future__ import annotations | ||
|
||
from typing import Any | ||
from typing_extensions import assert_type | ||
|
||
from useful_types import not_none | ||
|
||
|
||
def test(x: Any, y: str | None, z: str) -> None: | ||
assert_type(not_none(x), Any) | ||
assert_type(not_none(y), str) | ||
assert_type(not_none(z), str) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mypy fails on this one:
Possibly fixable with overloads, let me try that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, now pyright fails with something worse:
I think I prefer the version without overloads.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think might work with both if you reorder overloads?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, that way it doesn't narrow away the None at all, because None matches the first overload.