Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #167 #168

Merged
merged 2 commits into from
May 13, 2019
Merged

fix #167 #168

merged 2 commits into from
May 13, 2019

Conversation

tsbxmw
Copy link
Collaborator

@tsbxmw tsbxmw commented May 13, 2019 

    @locker
    def count_case(self, key: str, lock: m_lock=None):
        '''
        put case's commplete count to loader, from recorder to loader
        :param key:
        :param lock:
        :return:
        '''
        logger.debug(f"put case count {self.complete_case_count}", __name__)
        self.case_count.put(self.complete_case_count)
  • change case_count queue to max-count but not 1

@tsbxmw tsbxmw added the bug Something isn't working label May 13, 2019
@tsbxmw tsbxmw added this to the 3.0.0 milestone May 13, 2019
@tsbxmw tsbxmw self-assigned this May 13, 2019
@tsbxmw tsbxmw merged commit 107ab71 into master May 13, 2019
tsbxmw
tsbxmw commented May 16, 2019
View reviewed changes
haf/bus.py
@@ -57,7 +57,7 @@ def start_manager_server(self):
# runner queue to web server
publish_runner = Queue(maxsize=1)
# case count queue
case_count = Queue(maxsize=1)
case_count = Queue(maxsize=-1)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • here is the case_count queue to block the recorder!
  • so make the size of queue to the max-size

tsbxmw
tsbxmw commented May 16, 2019
View reviewed changes
haf/loader.py
cb.finish()
self.end_handler()
return
with new_locker(self.bus_client, self.key, self.lock):
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add new_locker when get/put the case_count

tsbxmw
tsbxmw commented May 16, 2019
View reviewed changes
haf/recorder.py
@@ -223,7 +222,7 @@ def result_handler(self, result):
:param result:
:return:
'''
self.count_case("case_count", self.lock)
self.count_case(self.recorder_key, self.lock)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add new_locker when get/put the case_count

tsbxmw
tsbxmw commented May 16, 2019
View reviewed changes
haf/asserthelper.py
@@ -34,6 +34,8 @@ def assert_that(real, expect, **kwargs):
result = True
for temp in real.keys():
result = result and AssertHelper.assert_that(real.get(temp), expect.get(temp))
for temp in expect.keys():
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here must check the real == expect, double check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tsbxmw tsbxmw

Labels
bug Something isn't working
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

haf running blocked
1 participant
@tsbxmw