This repository has been archived by the owner on Jun 12, 2024. It is now read-only.
generated from hay-kot/go-web-template
-
-
Notifications
You must be signed in to change notification settings - Fork 209
Add total price to label and location pages #722
Open
JackBailey
wants to merge
107
commits into
hay-kot:main
Choose a base branch
from
JackBailey:server-price-total
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* bump all deps * run code-gen
…t#506) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…t#508) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…ay-kot#451) * Fixed 3 places where API URLs were not constructed by function route(path, params). * autofix --------- Co-authored-by: Hayden <64056131+hay-kot@users.noreply.github.com>
* formatting * slimdown locations page * update location/labels * fix dependency issues * fix type generator * cleanup unused variables
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* add multiple new currencies * add multiple new currencies * remove duplicate yen
…port k… (hay-kot#526) * add support for create + add more for all create modals and support keyboard bindings * listen for esc to close modals
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…busting (hay-kot#527) * rough implementation of WS based event system for server side notifications of mutation * fix test construction * fix deadlock on event bus * disable linter error * add item mutation events * remove old event bus code * refactor event system to use composables * refresh items table when new item is added * fix create form errors * cleanup unnecessary calls * fix importer erorrs + limit fn calls on import
* Added currencies XAG and XAU to currency.ts I added XAG and XAU for myself and others who prefer to measure value with something of substance. Review the ISO 4217 standard to view a full list of official currency codes including the ones I have added. https://www.iso.org/iso-4217-currency-codes.html https://en.wikipedia.org/wiki/ISO_4217 Example: https://www.xe.com/currencyconverter/convert/?Amount=100&From=XAG&To=USD API for exchange rates: https://openexchangerates.org/ * Added field values xag and xau to group.go * Update group.go
* fix https connection * explicity dependency
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…ay-kot#676) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…kot#673) * feat: show quantity in card view if quantity == 0 (hay-kot#672) * Update frontend/components/Item/Card.vue --------- Co-authored-by: bee-eater <bee-eater@users.noreply.github.com> Co-authored-by: Hayden <64056131+hay-kot@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Quoing <pavel.cadersky@mavenir.com>
* basic currency service for loading at runtime * api endpoint for currencies * sort slice before return * remove currency validation * validate using currency service * implement selecting dynamic currency options * bump go version * fix type definition * specify explicit type * change go versions * proper types for assetId * log/return currency error * make case insensative * use ToUpper instead * feat: adding new currencies (hay-kot#715) * fix: task swag (hay-kot#710) Co-authored-by: Quoing <pavel.cadersky@mavenir.com> * [feat] Adding new currencies --------- Co-authored-by: quoing <quoing@users.noreply.github.com> Co-authored-by: Quoing <pavel.cadersky@mavenir.com> Co-authored-by: Bradley <41597815+userbradley@users.noreply.github.com> * remove ts file and consoldate new values into json * move flag to options namespace * add env config for currencies * basic documentaion * remove in sync test --------- Co-authored-by: quoing <quoing@users.noreply.github.com> Co-authored-by: Quoing <pavel.cadersky@mavenir.com> Co-authored-by: Bradley <41597815+userbradley@users.noreply.github.com>
Co-authored-by: zebrapurring <>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…-kot#668) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…0.17.0 (hay-kot#717) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
A way to build onto this could be adding the price directly on the item cards, and taking into consideration if the item is sold or not. However, especially for having the price on the cards, some people might not want these additions. So it might be a good idea to add them, but as an option - although this would probably be a fair bit larger of a change so more than I could personally cobble together in a language I've hardly touched. |
hay-kot
force-pushed
the
main
branch
2 times, most recently
from
January 28, 2024 03:49
b22ff27
to
d9497bd
Compare
JackBailey
changed the title
Add label and location total price
Add total price to label and location pages
Jan 31, 2024
Any thoughts @hay-kot? |
Hey! I do want to merge this. I still need to work through your approach, I think there may be some better ways to do this. I will try to get through the PR this week or next. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
It adds an indicator to the /label and /location pages to show the overall purchase price.
This is a modified version of #638, where calculation is performed on the backend, instead of the frontend, as requested by @hay-kot.
For locations it includes child locations.
Location
Label
Changed files:
Special notes for your reviewer:
I haven't used golang before, there's no errors and it works but it might not be done to the best way.
Testing
Labels
Locations
Release Notes