fixes for hazelcast-aws Github issues #29 and #22 #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-assigned this
ghost
requested review from
|
Test FAILed. |
|
Test FAILed. |
|
Test PASSed. |
|
Test PASSed. |
|
Test PASSed. |
…d in config file.
|
Test FAILed. |
|
Test PASSed. |
mesutcelik
approved these changes
Jun 29, 2017
| + "when given iam-role is also empty."); | ||
| } else { | ||
| if (!StringUtil.isNullOrEmptyAfterTrim(config.getIamRole())) { | ||
| getLogger().warning("No need to define iam-role, when access and secret keys are configured!"); |
There was a problem hiding this comment.
Can you please check this? It must be the other way around.
| + "please make sure EC2 instance have proper rights."); | ||
| return; | ||
| } | ||
| throw new InvalidConfigurationException("AWS Secret/Key must not be null or empty, " |
There was a problem hiding this comment.
That does not allow us not to configure anything regarding credentials...
emrahkocaman
approved these changes
Jun 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.