[BACKPORT] Calculate the initial frame size of the client messages correctly #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While calculating the initial frame size of the client messages, we were adding `SIZE_OF_FRAME_LENGTH_AND_FLAGS` twice. That extra addition is removed from the `create_initial_buffer`. To make the `create_initial_buffer_custom` alike, I also removed the addition from there, although there was no such problem for that method. To make it work again, I have modified the protocol template to perform one less subtraction of `SIZE_OF_FRAME_LENGTH_AND_FLAGS` from the initial frame size. Also, while I was there, I have updated the `sql_execute_codec`, and added support for the newly added parameter. * add a unit test that verifies the encoded requests produce the same bytearray as the Java client
mdumandag
force-pushed
the
protocol-fix-5.0.z
branch
from
f7f9fe7
to
6d454bf
Compare
Codecov Report
@@ Coverage Diff @@
## 5.0.z #499 +/- ##
==========================================
- Coverage 95.22% 94.88% -0.35%
==========================================
Files 346 346
Lines 17680 17680
==========================================
- Hits 16836 16775 -61
- Misses 844 905 +61
Continue to review full report at Codecov.
|
srknzl
approved these changes
Oct 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While calculating the initial frame size of the client messages,
we were adding
SIZE_OF_FRAME_LENGTH_AND_FLAGStwice. That extraaddition is removed from the
create_initial_buffer.To make the
create_initial_buffer_customalike, I also removedthe addition from there, although there was no such problem for that
method. To make it work again, I have modified the protocol template
to perform one less subtraction of
SIZE_OF_FRAME_LENGTH_AND_FLAGSfrom the initial frame size.
Also, while I was there, I have updated the
sql_execute_codec, andadded support for the newly added parameter.