Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BACKPORT] Calculate the initial frame size of the client messages correctly #499

Merged
merged 3 commits into from
Oct 14, 2021

Commits on Oct 13, 2021

  1. Calculate the initial frame size of the client messages correctly

    While calculating the initial frame size of the client messages,
    we were adding `SIZE_OF_FRAME_LENGTH_AND_FLAGS` twice. That extra
    addition is removed from the `create_initial_buffer`.
    
    To make the `create_initial_buffer_custom` alike, I also removed
    the addition from there, although there was no such problem for that
    method. To make it work again, I have modified the protocol template
    to perform one less subtraction of `SIZE_OF_FRAME_LENGTH_AND_FLAGS`
    from the initial frame size.
    
    Also, while I was there, I have updated the `sql_execute_codec`, and
    added support for the newly added parameter.
    
    * add a unit test that verifies the encoded requests produce the same bytearray as the Java client
    mdumandag committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    3210430 View commit details
    Browse the repository at this point in the history
  2. bump client version

    mdumandag committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    6d454bf View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2021

  1. Configuration menu
    Copy the full SHA
    0929cc1 View commit details
    Browse the repository at this point in the history