Release/v0.22.2 #1587
Merged
Release/v0.22.2 #1587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is None (#1571) In some situations, device.details has the scan response data only and advertising data is None. Since the ble address cannot be obtained from device.details.adv this time, the ble address is obtained from the device.details.scan (scan response data).
It is quite common for people to report "bugs" in Bleak because they are using it wrong. Now we can have a link to give them to explain this in detail.
The keys in the descriptor dict are the normalized 128-bit UUID string, so we need to use this to correctly find the descriptor. Fixes #823
#1581) In commit 4a653e6 ("backends/winrt: raise exception when trying to scan with STA") we added a check to raise an exception when trying to scan when PyWinRT set the apartment model to STA. However, properly working GUI apps will have the apartment model set to STA but Bleak will still work because there is something pumping the Windows message loop. We don't want to raise an exception in this case to avoid breaking working apps. We can improve the test by checking if the current thread is actually pumping the message loop by scheduling a callback via a the win32 SetTimeout function. If the callback is called, then we know that the message loop is being pumped. If not, then we probably are not going to get async callbacks from the WinRT APIs and we raise an exception in this case.
…#1586) It has been observed that the max MTU exchange may not be complete before the connection is established, at least on Windows. This reverts the previous attempt to work around this on Windows and instead makes the max_write_without_response_size dynamic. This way users can implement a workaround if needed but users who don't need it won't be punished with a longer connection time. The timeout in the previous workaround was also too short for some devices so it wasn't complexly fixing the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
BleakClientWinRTfrom scan response if advertising is None (WinRT).advattribute ofbleak.backends.winrt.scanner._RawAdvData.BleakGATTCharacteristic.max_write_without_response_sizeis now dynamic.Fixed
discovered_devices_and_advertisement_datareturning devices that shouldbe filtered out by service UUIDs. Fixes Service UUID filter does not apply to dict of discovered devices. #1576.
Descriptor None was not found!exception occurring instart_notify()on Android. Fixes I'm trying to connect to a BLE device via bleak - it works fine when I use client.start_notify on Windows 11 and andriod , but script fails , My logcat error: bleak.exc.BleakError: Descriptor None was not found! #823.BleakScannerwhile running in a Windows GUI app.