Tracker: split "edit issue" dialog to preview / edit #1731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@xored.com>
ghost
requested a review
from Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@xored.com>
haiodo
requested changes
May 12, 2022
| @@ -97,7 +98,9 @@ | |||
| </svelte:fragment> | |||
|
|
|||
| {#if withoutActivity} | |||
| <slot /> | |||
| <div class="popupPanel-body__main-content py-10 clear-mins"> | |||
There was a problem hiding this comment.
Why we need this one by default?
| } | ||
| </script> | ||
|
|
||
| {#if direction === 'column'} |
There was a problem hiding this comment.
I suppose for now we have only column direction always.
| }} | ||
| /> | ||
| {/if} | ||
| {#if isTitle} |
There was a problem hiding this comment.
I personally think we should have same header for both modes. So edit mode for us should just switch between title/description editor and not touch right part with status components.
|
In Short mode because of header missed button to show edit panel.
|
|
Conclusion:
|
added 3 commits
May 13, 2022 11:25
Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@xored.com>
Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@xored.com>
Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@xored.com>
added 5 commits
May 13, 2022 20:08
Also remove "preview issue" dialog Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@xored.com>
haiodo
reviewed
May 16, 2022
| {/if} | ||
|
|
||
| <div class="mt-6" on:click={(ev) => isDescriptionEmpty && edit(ev)}> | ||
| <StyledTextBox |
There was a problem hiding this comment.
Please use StyledTextBox in case of editing and MessageViewer if not
haiodo
reviewed
May 16, 2022
| <Button disabled={!canSave} label={presentation.string.Save} on:click={save} /> | ||
| {:else} | ||
| <Button icon={IconEdit} kind="transparent" size="medium" on:click={edit} /> | ||
| <Button icon={IconMoreH} kind="transparent" size="medium" /> |
There was a problem hiding this comment.
Please do not add useless components for now.
haiodo
reviewed
May 16, 2022
| @@ -0,0 +1,133 @@ | |||
| <!-- | |||
haiodo
reviewed
May 16, 2022
| @@ -13,6 +13,10 @@ | |||
| export let emphasized = false | |||
| export let alwaysEdit = false | |||
| export let showButtons = true | |||
| export let isEditable = true | |||
haiodo
reviewed
May 16, 2022
| @@ -13,6 +13,10 @@ | |||
| export let emphasized = false | |||
| export let alwaysEdit = false | |||
| export let showButtons = true | |||
| export let isEditable = true | |||
| export let isEmpty = false | |||
| export let isScrollable = true | |||
There was a problem hiding this comment.
TextBox doesn't assume scrolling. Please make something like StyledTextArea.
added 6 commits
May 16, 2022 15:30
Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@xored.com>
Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@xored.com>
Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@xored.com> # Conflicts: # plugins/tracker-assets/lang/en.json # plugins/tracker-resources/src/components/issues/EditIssue.svelte # plugins/tracker-resources/src/components/issues/PriorityEditor.svelte # plugins/tracker-resources/src/components/issues/StatusEditor.svelte
Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@xored.com>
Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@xored.com>
Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@xored.com>
haiodo
reviewed
May 16, 2022
|
|
||
| const handlePriorityChanged = async (newPriority: IssuePriority | undefined) => { | ||
| if (!isEditable || newPriority === undefined || value.priority === newPriority) { | ||
| return | ||
| } | ||
|
|
||
| await client.update(value, { priority: newPriority }) | ||
| dispatch('change', newPriority) |
There was a problem hiding this comment.
I suppose we discussed to always update from this kind of editors?
added 2 commits
May 17, 2022 17:28
Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@xored.com>
haiodo
approved these changes
May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #1272