-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracker: split "edit issue" dialog to preview / edit #1731
Changes from 2 commits
dc33520
0d5aa9b
b6ff036
c4ae8db
960ea59
b57bbcd
e8569ef
0eed12c
961d122
f01ee7a
3c76ff0
a561c99
6e847b6
463d3b0
9b13382
47aca59
8401a03
4aa1efa
e88231b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,6 +18,7 @@ | |
|
||
export let innerWidth: number = 0 | ||
export let panelWidth: number = 0 | ||
export let isTitle: boolean = true | ||
export let isHeader: boolean = true | ||
export let isAside: boolean = true | ||
|
||
|
@@ -33,32 +34,34 @@ | |
</script> | ||
|
||
<div class="popupPanel" bind:clientWidth={panelWidth}> | ||
<div class="popupPanel-title"> | ||
<Button | ||
icon={IconClose} | ||
kind={'transparent'} | ||
size={'medium'} | ||
on:click={() => { | ||
dispatch('close') | ||
}} | ||
/> | ||
<div class="popupPanel-title__content"><slot name="title" /></div> | ||
<div class="buttons-group xsmall-gap"> | ||
<slot name="utils" /> | ||
{#if asideFloat && $$slots.aside && isAside} | ||
{#if $$slots.utils}<div class="buttons-divider" />{/if} | ||
<Button | ||
icon={IconDetails} | ||
kind={'transparent'} | ||
size={'medium'} | ||
selected={asideShown} | ||
on:click={() => { | ||
asideShown = !asideShown | ||
}} | ||
/> | ||
{/if} | ||
{#if isTitle} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I personally think we should have same header for both modes. So edit mode for us should just switch between title/description editor and not touch right part with status components. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done. |
||
<div class="popupPanel-title"> | ||
<Button | ||
icon={IconClose} | ||
kind={'transparent'} | ||
size={'medium'} | ||
on:click={() => { | ||
dispatch('close') | ||
}} | ||
/> | ||
<div class="popupPanel-title__content"><slot name="title" /></div> | ||
<div class="buttons-group xsmall-gap"> | ||
<slot name="utils" /> | ||
{#if asideFloat && $$slots.aside && isAside} | ||
{#if $$slots.utils}<div class="buttons-divider" />{/if} | ||
<Button | ||
icon={IconDetails} | ||
kind={'transparent'} | ||
size={'medium'} | ||
selected={asideShown} | ||
on:click={() => { | ||
asideShown = !asideShown | ||
}} | ||
/> | ||
{/if} | ||
</div> | ||
</div> | ||
</div> | ||
{/if} | ||
<div class="popupPanel-body" class:asideShown> | ||
<div class="popupPanel-body__main" bind:clientWidth={innerWidth}> | ||
{#if $$slots.header && isHeader} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why we need this one by default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed.