Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Activity: filters #2395

Merged
merged 5 commits into from
Nov 27, 2022
Merged

Activity: filters #2395

merged 5 commits into from
Nov 27, 2022

Conversation

SasLord
Copy link
Member

@SasLord SasLord commented Nov 24, 2022 •
edited
Loading

Signed-off-by: Alexander Platov sas_lord@mail.ru

Contribution checklist

Brief description

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues
TSK-430

@SasLord
Activity: filters
29ea414 
Signed-off-by: Alexander Platov <sas_lord@mail.ru>
@SasLord
Add filters
23d69ab 
Signed-off-by: Alexander Platov <sas_lord@mail.ru>
@SasLord
Merge branch 'main' into add-activity-filters
6f0c459 
Signed-off-by: Alexander Platov <sas_lord@mail.ru>
@SasLord
Fix versions
d9d724b 
Signed-off-by: Alexander Platov <sas_lord@mail.ru>
@SasLord SasLord marked this pull request as ready for review November 27, 2022 02:24
haiodo
haiodo requested changes Nov 27, 2022
View reviewed changes
models/activity/package.json Outdated Show resolved Hide resolved
models/activity/src/index.ts Outdated Show resolved Hide resolved
models/activity/src/index.ts Outdated Show resolved Hide resolved
@SasLord
Fix
5212e22 
Signed-off-by: Alexander Platov <sas_lord@mail.ru>
@haiodo haiodo merged commit 90bc1da into main Nov 27, 2022
@haiodo haiodo deleted the add-activity-filters branch November 27, 2022 16:05
disant1 pushed a commit that referenced this pull request Nov 29, 2022
@SasLord @disant1
Activity: filters (#2395)
d2b9e57 
* Activity: filters
Signed-off-by: Alexander Platov <sas_lord@mail.ru>
mrsadman99 pushed a commit that referenced this pull request Dec 1, 2022
Merge branch 'main' into TSK-425
b81c907 
* main:
  Add sortable list (#2403)
  Update EditDoc layout (#2402)
  Export special view for reuse (#2401)
  Hr fixes (#2397)
  Fix Popup for @ document referencing and Emoji popup (#2398)
  Activity: filters (#2395)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haiodo haiodo haiodo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SasLord @haiodo