Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EditDoc layout #2402

Merged
merged 1 commit into from
Nov 30, 2022
Merged

Update EditDoc layout #2402

merged 1 commit into from
Nov 30, 2022

Conversation

SasLord
Copy link
Member

@SasLord SasLord commented Nov 29, 2022 •
edited by huly-github-staging bot
Loading

Signed-off-by: Alexander Platov sas_lord@mail.ru

Contribution checklist

Brief description

Снимок экрана 2022-11-30 в 02 22 01 Снимок экрана 2022-11-30 в 01 30 02

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues TSK-444

View in Huly UBERF-1830

@SasLord
Update EditDoc layout
d781ece 
Signed-off-by: Alexander Platov <sas_lord@mail.ru>
haiodo
haiodo reviewed Nov 30, 2022
View reviewed changes
plugins/recruit-resources/src/components/Applications.svelte
query={{ attachedTo: objectId }}
loadingProps={{ length: applications }}
/>
{#if wSection < 640}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be we should move this scroll logic into Table? Or Create ScrolledTable?

@haiodo haiodo merged commit a8a8f80 into main Nov 30, 2022
@haiodo haiodo deleted the fix-444 branch November 30, 2022 05:53
mrsadman99 pushed a commit that referenced this pull request Dec 1, 2022
Merge branch 'main' into TSK-425
b81c907 
* main:
  Add sortable list (#2403)
  Update EditDoc layout (#2402)
  Export special view for reuse (#2401)
  Hr fixes (#2397)
  Fix Popup for @ document referencing and Emoji popup (#2398)
  Activity: filters (#2395)
disant1 pushed a commit that referenced this pull request Dec 5, 2022
@SasLord @disant1
Update EditDoc layout (#2402)
28aa419 
Signed-off-by: Alexander Platov <sas_lord@mail.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haiodo haiodo haiodo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SasLord @haiodo