fix(report-aggregate) Fix report aggregation #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aurelien-baudet
commented
Jun 19, 2019
aurelien-baudet
commented
- [pitest-maven] report-aggregate fails due to test dependencies #621: do not use test dependencies as test source directories
- [pitest-maven] report-aggregate fails while loading mutator class #622: use the name of the mutator (it is not a class name written in mutations.xml)
aurelien-baudet
force-pushed
the
fix/report-aggregation
branch
from
b50284f to
67c5a5c
Compare
|
I would really appreciate if we could have the aggregation fixed |
|
@hcoles Could you review the PR and merge it if it is OK for you ? Also for the new score calculation, I could add some screenshots and examples to illustrate the interest if you want |
- hcoles#621: do not use test dependencies as test source directories - hcoles#622: use the name of the mutator (it is not a class name written in mutations.xml)
In a real world project with many submodules and particularly a module that has dependencies to other modules, the generated reports can be quite heavy (100MB+). When these reports are parsed using current XML parser, report aggregation fails with GC overhead limit or OutOfMemoryError due to loading of the whole XML data in memory. The new implementation uses StAX in order to avoid loading the whole XML data in memory.
aurelien-baudet
force-pushed
the
fix/report-aggregation
branch
from
77a5b7e to
1cf7d55
Compare
|
@hcoles I have rebased the PR with latest changes to fix report aggregation. Can you merge with master ? |
|
I also would like to see this fixed. |
|
@aurelien-baudet Sorry for the silence. If you can resolve the conflicts again and confirm it works, I'll merge this in. |
|
Sorry but I have currently no time. Moreover, I rebased the code 3 times to resolve conflicts but it had never been merged... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.