-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't override col_cls in DynamicTable.add_column #1091
Open
rly
wants to merge
13
commits into
dev
Choose a base branch
from
rly-patch-1
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+69
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will this be in by next milestone? |
Please let us know when it gets in. We are relying on it for implementation of ndx-hed. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1091 +/- ##
==========================================
- Coverage 87.18% 87.00% -0.18%
==========================================
Files 42 42
Lines 9532 9537 +5
Branches 1922 1926 +4
==========================================
- Hits 8310 8298 -12
- Misses 908 918 +10
- Partials 314 321 +7 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Issue: If a user extends
DynamicTableRegion
orEnumData
and tries to create a column with that subclass, using thetable
orenum
keyword args, their subclass argument gets replaced with the baseDynamicTableRegion
orEnumData
classes.Solution: Use the passed col_cls. If not provided, then use the base
DynamicTableRegion
orEnumData
classes.TODO: Add a quick test
Checklist
CHANGELOG.md
with your changes?