Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't override col_cls in DynamicTable.add_column #1091

Open
wants to merge 13 commits into
base: dev
Choose a base branch
from
Open

Conversation

rly
Copy link
Contributor

@rly rly commented Apr 4, 2024

Motivation

Issue: If a user extends DynamicTableRegion or EnumData and tries to create a column with that subclass, using the table or enum keyword args, their subclass argument gets replaced with the base DynamicTableRegion or EnumData classes.
Solution: Use the passed col_cls. If not provided, then use the base DynamicTableRegion or EnumData classes.

TODO: Add a quick test

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Does the PR clearly describe the problem and the solution?
  • Have you reviewed our Contributing Guide?
  • Does the PR use "Fix #XXX" notation to tell GitHub to close the relevant issue numbered XXX when the PR is merged?

@mavaylon1
Copy link
Contributor

Will this be in by next milestone?

@VisLab
Copy link

VisLab commented Apr 26, 2024

Please let us know when it gets in. We are relying on it for implementation of ndx-hed.

Copy link

codecov bot commented Jan 18, 2025

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.00%. Comparing base (775fa3b) to head (b4f33ef).

Files with missing lines Patch % Lines
src/hdmf/common/table.py 92.30% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1091      +/-   ##
==========================================
- Coverage   87.18%   87.00%   -0.18%     
==========================================
  Files          42       42              
  Lines        9532     9537       +5     
  Branches     1922     1926       +4     
==========================================
- Hits         8310     8298      -12     
- Misses        908      918      +10     
- Partials      314      321       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rly rly marked this pull request as ready for review January 21, 2025 22:07
@rly rly requested a review from mavaylon1 January 21, 2025 22:16
@rly rly enabled auto-merge (squash) January 21, 2025 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants