-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
frontend: Add /crs page to display a list of all instantiated custom resources. #2226
frontend: Add /crs page to display a list of all instantiated custom resources. #2226
Conversation
2a0b428
to
ab7c058
Compare
For the Build Frontend / test (20.x, ubuntu-22.04) action, should I edit the snapshots to add the new sidebar item ? |
ab7c058
to
f239907
Compare
f239907
to
3244a66
Compare
I think that at this point it probably makes more sense to have Custom Resources as a top level sidebar entry. Because Custom Resources + Custom Resource Instances looks a bit odd as separate items. But we should do that in a separate PR. |
as discussed in headlamp-k8s#2226 Signed-off-by: guilhane <guilhane.bourgoin@orange.com>
I want to understand better why the instances view is needed. What's the value it brings that you don't get with the current Custom Resources page in Headlamp. IMO, just like you have to navigate between resource kinds across the UI (Pod, ConfigMaps, etc.) before you see the list of definitions, it's similar when going to the list of Resource kinds in the current CR page in Headlamp (where the first column there has the kinds). |
@Guilamb Okay. I think this makes sense. Let's mix this together with a higher level Custom Resources sidebar item as we talked about. |
Hi @Guilamb . Yes please. Transfer it here. |
3244a66
to
d3308a3
Compare
as discussed in headlamp-k8s#2226 Signed-off-by: guilhane <guilhane.bourgoin@orange.com>
Hi, Should be ok, I've added the sidebar as required and I'm closing the other PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Guilamb . I have reviewed the sidebar. I will review the rest later.
as discussed in headlamp-k8s#2226 Signed-off-by: guilhane <guilhane.bourgoin@orange.com>
c457a06
to
f7d4557
Compare
Thanks, I'll correct this. Also when showing the changes to @gberche, he spotted a problem with the filtering in the CR page. |
For "Build Frontend / test"... You might need to rebase against main, The failing "Build Frontend / test plugins" which just hangs on CI is unrelated to this. Ignore this one for now, I am currently working on a fix. |
Fixes: headlamp-k8s#1962 Signed-off-by: guilhane <guilhane.bourgoin@orange.com>
as discussed in headlamp-k8s#2226 Signed-off-by: guilhane <guilhane.bourgoin@orange.com>
Signed-off-by: guilhane <guilhane.bourgoin@orange.com>
8fb9063
to
bc076fa
Compare
@Guilamb I think some snapshots are failing. Are you able to update them? |
Hello, I couldn't find out how to update them. |
as discussed in #2226 Signed-off-by: guilhane <guilhane.bourgoin@orange.com>
as discussed in #2226 Signed-off-by: guilhane <guilhane.bourgoin@orange.com>
Closing in favor of #2356 . |
as discussed in #2226 Signed-off-by: guilhane <guilhane.bourgoin@orange.com>
Description
This pull request addresses the issue of restricted user access to custom resources and the need to view only the instantiated custom resources (#955 ), by introducing a new /crs page in Headlamp that displays a list of all instantiated custom resources, that can be filtered by category.
The /crs page provides users with the capability to view their Resource Status and Definitions without requiring the development of a custom UI. It also allows users to filter namespaces, similar to the existing functionality for Workloads, ensuring restricted permissions are maintained.
Changes
To implement this feature, the following changes were made:
Fixes: #1962
Signed-off-by: guilhane guilhane.bourgoin@orange.com