Add custom resource instances page #2356
Open
+399
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
sniok
reviewed
Sep 27, 2024
|
|
||
| for (const crd of crds) { | ||
| const crClass = crd.makeCRClass(); | ||
| const [crItems, crError] = await new Promise<[KubeCRD[] | null, any | null]>(resolve => { |
There was a problem hiding this comment.
these requests are made one after another, Promise.all would allow doing them concurrently. Or maybe even using react-query?
There was a problem hiding this comment.
Yeah. I was modifying just that today 😄
About react-query, I only saw examples of it using a hook, which in this case of iterating through objects is not ideal. I will see if they have a non-hook API.
…resources. Fixes: #1962 Signed-off-by: guilhane <guilhane.bourgoin@orange.com> NOTE: Add prefix to the base commit title. Signed-off-by: Joaquim Rocha <joaquim.rocha@microsoft.com>
Use react-query for fetching the instances of just a plain API fetch. Signed-off-by: Joaquim Rocha <joaquim.rocha@microsoft.com>
|
@sniok I have done an attempt on adding react-query but I am not sure this is performing more fetches than needed (maybe triggering an infinite loop in some cases). Can you double check? |
sniok
force-pushed
the
add-customResource-instances-page
branch
2 times, most recently
from
e0241d7
to
2bf5ef3
Compare
Signed-off-by: Oleksandr Dubenko <oldubenko@microsoft.com>
sniok
force-pushed
the
add-customResource-instances-page
branch
from
2bf5ef3
to
38c08c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(taken from #2226 as the author @Guilamb has no availability to work on it anymore)
This pull request addresses the issue of restricted user access to custom resources and the need to view only the instantiated custom resources (#955 ), by introducing a new CR instances page in Headlamp that displays a list of all instantiated custom resources, that can be filtered by category.
The CR instances page provides users with the capability to view their Resource Status and Definitions without requiring the development of a custom UI. It also allows users to filter namespaces, similar to the existing functionality for Workloads, ensuring restricted permissions are maintained.
Fixes: #1962