Remove pass_by_value property (#522)

heavyai · Dec 22, 2022 · 4f73a8a · 4f73a8a
1 parent 33b24f9
commit 4f73a8a
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 13 deletions.
diff --git a/rbc/heavydb/buffer.py b/rbc/heavydb/buffer.py
@@ -43,12 +43,6 @@
 class HeavyDBBufferType(HeavyDBAbstractType):
     """Typesystem type class for HeavyDB buffer structures.
     """
-    # When True, buffer type arguments are passed by value to
-    # functions [not recommended].
-    @property
-    def pass_by_value(self):
-        return False
-
     @property
     def numba_type(self):
         return BufferType
@@ -92,8 +86,6 @@ def tonumba(self, bool_is_int8=None):
         )
         buffer_type.params(other=None, **self.custom_params)
         numba_type = buffer_type.tonumba(bool_is_int8=True)
-        if self.pass_by_value:
-            return numba_type
         return self.numba_pointer_type(numba_type)
 
 

diff --git a/rbc/heavydb/column.py b/rbc/heavydb/column.py
@@ -35,11 +35,6 @@ def postprocess_type(self):
             return self.copy(cls=HeavyDBOutputColumnArrayType)
         return self
 
-    @property
-    def pass_by_value(self):
-        heavydb_version = TargetInfo().software[1][:3]
-        return heavydb_version <= (5, 7, 0)
-
     def match(self, other):
         if type(self) is type(other):
             return self[0] == other[0]