Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pass_by_value property #522

Merged
merged 1 commit into from
Dec 22, 2022
Merged

Remove pass_by_value property #522

merged 1 commit into from
Dec 22, 2022

Conversation

guilhermeleobas
Copy link
Contributor

Fix #342

@guilhermeleobas guilhermeleobas added enhancement New feature or request heavydb Related to heavydb server labels Dec 14, 2022
@guilhermeleobas guilhermeleobas self-assigned this Dec 14, 2022
@guilhermeleobas guilhermeleobas force-pushed the guilhermeleobas/remove_pass_by_value branch from 34b28f1 to f173b28 Compare December 14, 2022 19:51
@guilhermeleobas guilhermeleobas force-pushed the guilhermeleobas/remove_pass_by_value branch from f173b28 to 07f194d Compare December 15, 2022 18:18
pearu
pearu approved these changes Dec 22, 2022
View reviewed changes
Copy link
Contributor

@pearu pearu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, @guilhermeleobas!

@pearu pearu merged commit 4f73a8a into heavyai:main Dec 22, 2022
@guilhermeleobas guilhermeleobas deleted the guilhermeleobas/remove_pass_by_value branch December 22, 2022 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pearu pearu pearu approved these changes

Assignees

@guilhermeleobas guilhermeleobas

Labels
enhancement New feature or request heavydb Related to heavydb server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove pass_by_value property when omnisci v5.9 is released
2 participants
@guilhermeleobas @pearu