Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pass_by_value property #522

Merged
merged 1 commit into from
Dec 22, 2022
Merged

Remove pass_by_value property #522

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions rbc/heavydb/buffer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,6 @@
class HeavyDBBufferType(HeavyDBAbstractType):
"""Typesystem type class for HeavyDB buffer structures.
"""
# When True, buffer type arguments are passed by value to
# functions [not recommended].
@property
def pass_by_value(self):
return False

@property
def numba_type(self):
return BufferType
Expand Down Expand Up @@ -92,8 +86,6 @@ def tonumba(self, bool_is_int8=None):
)
buffer_type.params(other=None, **self.custom_params)
numba_type = buffer_type.tonumba(bool_is_int8=True)
if self.pass_by_value:
return numba_type
return self.numba_pointer_type(numba_type)


Expand Down
5 changes: 0 additions & 5 deletions rbc/heavydb/column.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,6 @@ def postprocess_type(self):
return self.copy(cls=HeavyDBOutputColumnArrayType)
return self

@property
def pass_by_value(self):
heavydb_version = TargetInfo().software[1][:3]
return heavydb_version <= (5, 7, 0)

def match(self, other):
if type(self) is type(other):
return self[0] == other[0]
Expand Down