-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove backward pipe #276
Remove backward pipe #276
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. We could merge after you're done with @TysonMN's suggestion (or when you and Tyson are ready). 💯
I think this is ready for another round of review. |
Property.print <| property { | ||
Property.print (property { | ||
let! xs = Gen.list (Range.linear 0 100) version | ||
return xs |> List.rev = xs | ||
} | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would do either
property {
} |> Property.print
or
property {
}
|> Property.print
but this is fine too.
There are other cases like this. I won't comment on them until we decide what is preferred here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I would prefer
let name =
property {
// ..
}
Property.print name
Often times F# code plays chicken with the off-side rule and I'd rather just be blunt and direct.
This is actually one situation where I think <|
makes perfect sense to use. Passing a CE directly to a function as the last (or only) parameter, when no other piping is being used.
Property.print <| property {
// ...
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am fine with anything here
Co-authored-by: Nikos Baxevanis <nikos.baxevanis@gmail.com>
Pipeline failed because of some random "Unable to download dependencies" issue, is there a way to re-run the build? |
I just rerun the pipeline. 👍 |
Alrighty, ready to merge? |
Yep |
🚀 |
As part of a discussion on #274 there was a question about removing usages of the
<|
operator. This PR demonstrates what that would look like, and is also merge-able./cc @moodmosaic @TysonMN