OIDC logout #3456
Merged
OIDC logout #3456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
danielkec
reviewed
Oct 7, 2021
security/providers/oidc/src/main/java/io/helidon/security/providers/oidc/OidcProvider.java
Show resolved
Hide resolved
danielkec
reviewed
Oct 7, 2021
...viders/oidc-common/src/main/java/io/helidon/security/providers/oidc/common/OidcMetadata.java
Outdated
Show resolved
Hide resolved
danielkec
reviewed
Oct 7, 2021
...viders/oidc-common/src/main/java/io/helidon/security/providers/oidc/common/OidcMetadata.java
Outdated
Show resolved
Hide resolved
...s/oidc-common/src/main/java/io/helidon/security/providers/oidc/common/OidcCookieHandler.java
Outdated
Show resolved
Hide resolved
...roviders/oidc-common/src/main/java/io/helidon/security/providers/oidc/common/OidcConfig.java
Outdated
Show resolved
Hide resolved
...roviders/oidc-common/src/main/java/io/helidon/security/providers/oidc/common/OidcConfig.java
Outdated
Show resolved
Hide resolved
...roviders/oidc-common/src/main/java/io/helidon/security/providers/oidc/common/OidcConfig.java
Outdated
Show resolved
Hide resolved
security/jwt/src/main/java/io/helidon/security/jwt/JwtHeaders.java
Outdated
Show resolved
Hide resolved
microprofile/jwt-auth/src/main/java/io/helidon/microprofile/jwt/auth/JwtAuthProvider.java
Outdated
Show resolved
Hide resolved
# Conflicts: # security/providers/oidc-common/pom.xml # security/providers/oidc-common/src/main/java/module-info.java
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
danielkec
approved these changes
Oct 14, 2021
dalexandrov
pushed a commit
to dalexandrov/helidon
that referenced
this pull request
Oct 21, 2021
* Support for OIDC logout when using cookies. * Refactored OidcConfig as it was too big. * Only require encryption for the id token when it is expected to be used. Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3306
I had to refactor
OidcConfig, as thebuildmethod was too long, and the class had too many lines (reported by checkstyle).New features:
/oidc/logout- removes Helidon cookies, redirects to OIDC server to log out)Logout is disabled by default, as it requires an unsecured "post-logout-uri" to work correctly. Also as encryption is required, users should provide either a master password or a encryption configuration name.