OIDC - redirect URL frontend-uri built from req if left out of config #3457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update from oracle
|
/oca-checked |
|
Hello @jmntn2000, we have a parallel PR in progress (#3456) that needs a similar change. If you would be OK with it, I would take over your work and finish it once that PR is merged. I will keep your commit in to preserve the contribution. |
That is fine with me. Thank you. |
|
I have created an issue for this: #3583 |
|
Part is resolved by #3584 |
|
Follow up issue #3590, closing this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a multi-tenant environment or any instance of multiple host names resolving to same IP the frontend-uri can not be hard coded in the config file for OIDC redirect. If this is left out of the config then it is now build from the request.