Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Hamcrest assertions instead of JUnit in common/common - backport helidon-2.x (#1749) #4906

Conversation

Captain1653
Copy link
Contributor

@Captain1653 Captain1653 commented Sep 16, 2022

Part of #1749 .

Backport helidon-2.x, details can be found here .

I've already signed OCA.

@romain-grecourt
Copy link
Contributor

/oca-checked

@romain-grecourt
Copy link
Contributor

/trigger

@Captain1653
Copy link
Contributor Author

The build was green and then became red. Some tests failed, but I didn't touch them.
Screenshot 2022-09-19 at 22 57 57

@romain-grecourt
Copy link
Contributor

The merge pipeline re-runs every time the target branch is updated. You got unlucky and ran into some intermittent test failures.

@romain-grecourt romain-grecourt self-assigned this Sep 23, 2022
@romain-grecourt romain-grecourt merged commit 31bb695 into helidon-io:helidon-2.x Sep 27, 2022
@Captain1653 Captain1653 deleted the 1749-common-common-backport branch September 28, 2022 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants