Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Hamcrest assertions instead of JUnit #1749

Open
4 of 55 tasks
tomas-langer opened this issue May 7, 2020 · 5 comments
Open
4 of 55 tasks

Use Hamcrest assertions instead of JUnit #1749

tomas-langer opened this issue May 7, 2020 · 5 comments
Assignees
@danielkec
Labels
2.x Issues for 2.x version branch 3.x Issues for 3.x version branch 4.x Version 4.x help wanted Extra attention is needed P4 testing

Comments

@tomas-langer
Copy link
Member

tomas-langer commented May 7, 2020 •
edited by danielkec
Loading

Environment Details

  • Helidon Version: 2.0.0
  • Whole code base

Problem Description

Currently we have a few tests that still use JUnit assertions, such as
assertEquals(actual, expected, "Test a and b are equal")
all of these should be replaced with Hamcrest, such as:
assertThat("Test a and b are equal", actual, is(expected)))

There are a few assertions we can use:
fail("")
assertAll()
assertThrows

  • archetypes/se/target/test-classes/projects/it1/project/it1
  • archetypes/se/target/test-classes/projects/it2/project/it2
  • archetypes/se/target/test-classes/projects/it3/project/it3
  • common/common
  • common/http
  • common/reactive
  • config/encryption
  • config/object-mapping
  • dbclient/jdbc
  • dbclient/mongodb
  • examples/cors
  • examples/employee-app
  • examples/microprofile/hello-world-implicit
  • examples/microprofile/mp1_1-static-content
  • examples/microprofile/openapi-basic
  • examples/openapi
  • examples/quickstarts/helidon-quickstart-mp
  • examples/quickstarts/helidon-quickstart-se
  • examples/quickstarts/helidon-standalone-quickstart-mp
  • examples/quickstarts/helidon-standalone-quickstart-se
  • examples/webserver/basics
  • examples/webserver/comment-aas
  • examples/webserver/jersey
  • examples/webserver/tutorial
  • integrations/cdi/common-cdi/reference-counted-context
  • integrations/cdi/datasource-hikaricp
  • integrations/cdi/datasource-ucp
  • integrations/cdi/eclipselink-cdi
  • integrations/cdi/jpa-cdi
  • integrations/cdi/jpa-weld
  • integrations/cdi/jta-cdi
  • integrations/cdi/jta-weld
  • integrations/cdi/oci-objectstorage-cdi
  • media/common
  • messaging/kafka
  • messaging/messaging
  • metrics/metrics
  • microprofile/config
  • microprofile/fault-tolerance
  • microprofile/jwt-auth
  • microprofile/messaging
  • microprofile/reactive-streams
  • microprofile/openapi
  • microprofile/websocket
  • openapi
  • security/providers/oidc-common
  • tests/apps/bookstore/bookstore-mp
  • tests/apps/bookstore/bookstore-se
  • tests/apps/bookstore/common
  • tests/integration/kafka
  • tests/integration/mp-ws-services
  • tests/integration/native-image/se-1
  • tests/integration/webclient
  • webserver/jersey
  • webserver/tyrus
@danielkec danielkec mentioned this issue May 11, 2020
Merged
@m0mus m0mus modified the milestone: 2.0.0 May 14, 2020
@tomas-langer tomas-langer added the 2.x Issues for 2.x version branch label May 14, 2020
@m0mus m0mus added the P4 label May 14, 2020
Captain1653 added a commit to Captain1653/helidon that referenced this issue Sep 14, 2022
@Captain1653
Use Hamcrest assertions instead of JUnit in common/common (helidon-io…
cdafbf9 
…#1749)
@Captain1653 Captain1653 mentioned this issue Sep 14, 2022
Merged
Captain1653 added a commit to Captain1653/helidon that referenced this issue Sep 15, 2022
@Captain1653
Use Hamcrest assertions instead of JUnit in common/http (helidon-io#1749
eb0c728 
)
@Captain1653 Captain1653 mentioned this issue Sep 15, 2022
Merged
romain-grecourt pushed a commit that referenced this issue Sep 15, 2022
@Captain1653
Use Hamcrest assertions instead of JUnit in common/http (#1749) (#4898)
b2cdcef
romain-grecourt pushed a commit that referenced this issue Sep 15, 2022
@Captain1653
Use Hamcrest assertions instead of JUnit in common/common (#1749) (#4886
d23abf4 
)
@romain-grecourt
Copy link
Contributor

Two items have been fixed in helidon-3.x, and will need to be backported in 2.x:

@Captain1653
Copy link
Contributor

@romain-grecourt Can any contributor (not a member of helidon) do backport? I can try to do it. Are there any instructions for backport process in the documentation?

@romain-grecourt
Copy link
Contributor

You can do a backport. There is no special process at the moment (though we've been working on one recently).

A git cherry-pick should do the trick.

Captain1653 added a commit to Captain1653/helidon that referenced this issue Sep 16, 2022
@Captain1653
Use Hamcrest assertions instead of JUnit in common/common - backport …
acb5ce6 
…helidon-2.x (helidon-io#1749)
@Captain1653 Captain1653 mentioned this issue Sep 16, 2022
Merged
Captain1653 added a commit to Captain1653/helidon that referenced this issue Sep 16, 2022
@Captain1653
Use Hamcrest assertions instead of JUnit in common/http - backport he…
9720b7a 
…lidon-2.x (helidon-io#1749)
@Captain1653 Captain1653 mentioned this issue Sep 16, 2022
Merged
Captain1653 added a commit to Captain1653/helidon that referenced this issue Sep 17, 2022
@Captain1653
Use Hamcrest assertions instead of JUnit in common/reactive (helidon-…
a67d5cf 
…io#1749)
@Captain1653 Captain1653 mentioned this issue Sep 17, 2022
Merged
1 task
Captain1653 added a commit to Captain1653/helidon that referenced this issue Sep 21, 2022
@Captain1653
Use Hamcrest assertions instead of JUnit in integrations/cdi/common-c…
5ff30a6 
…di/reference-counted-context (helidon-io#1749)
@Captain1653 Captain1653 mentioned this issue Sep 21, 2022
Merged
1 task
romain-grecourt pushed a commit that referenced this issue Sep 23, 2022
@Captain1653
Use Hamcrest assertions instead of JUnit in integrations/cdi/common-c…
47dcc74 
…di/reference-counted-context (#1749) (#4927)
romain-grecourt pushed a commit that referenced this issue Sep 23, 2022
@Captain1653
Use Hamcrest assertions instead of JUnit in common/http - backport he…
512a4c4 
…lidon-2.x (#1749) (#4907)
Captain1653 added a commit to Captain1653/helidon that referenced this issue Sep 23, 2022
@Captain1653
Use Hamcrest assertions instead of JUnit in integrations/cdi/common-c…
6d8f335 
…di/reference-counted-context - backport 2.x (helidon-io#1749)
@Captain1653 Captain1653 mentioned this issue Sep 23, 2022
Merged
Captain1653 added a commit to Captain1653/helidon that referenced this issue Sep 23, 2022
@Captain1653
Use Hamcrest assertions instead of JUnit in common/reactive - backpor…
9a2b7ec 
…t 2.x (helidon-io#1749)
Captain1653 added a commit to Captain1653/helidon that referenced this issue Apr 18, 2023
@Captain1653
[4.x]: Use Hamcrest assertions instead of JUnit in tests/integration/…
d24d3a9 
…jms (helidon-io#1749)
@Captain1653 Captain1653 mentioned this issue Apr 18, 2023
Merged
Captain1653 added a commit to Captain1653/helidon that referenced this issue Apr 18, 2023
@Captain1653
[2.x]: Use Hamcrest assertions instead of JUnit in tests/integration/…
005d866 
…jms (helidon-io#1749)
@Captain1653 Captain1653 mentioned this issue Apr 18, 2023
Merged
romain-grecourt pushed a commit that referenced this issue Apr 19, 2023
@Captain1653
[4.x]: Use Hamcrest assertions instead of JUnit in tests/integration/…
9f2156f 
…jms (#1749) (#6643)
romain-grecourt pushed a commit that referenced this issue Apr 19, 2023
@Captain1653
[2.x]: Use Hamcrest assertions instead of JUnit in tests/integration/…
a446551 
…jms (#1749) (#6645)
romain-grecourt pushed a commit to Captain1653/helidon that referenced this issue Apr 21, 2023
@Captain1653 @romain-grecourt
Use Hamcrest assertions instead of JUnit in integrations/cdi/jpa-cdi …
a10f503 
…- backport 2.x (helidon-io#1749)
Captain1653 added a commit to Captain1653/helidon that referenced this issue Apr 21, 2023
@Captain1653
Add hamcrest-all to dependencies of eclipselink-maven-plugin (helidon…
778fde9 
…-io#1749)
romain-grecourt pushed a commit to Captain1653/helidon that referenced this issue Jun 5, 2023
@Captain1653 @romain-grecourt
Use Hamcrest assertions instead of JUnit in integrations/cdi/jpa-cdi …
0cb82a9 
…- backport 2.x (helidon-io#1749)
romain-grecourt pushed a commit to Captain1653/helidon that referenced this issue Jun 5, 2023
@Captain1653 @romain-grecourt
Add hamcrest-all to dependencies of eclipselink-maven-plugin (helidon…
a17cb0d 
…-io#1749)
romain-grecourt pushed a commit to Captain1653/helidon that referenced this issue Jun 5, 2023
@Captain1653 @romain-grecourt
Use Hamcrest assertions instead of JUnit in integrations/cdi/jpa-cdi …
5207206 
…- backport 2.x (helidon-io#1749)
romain-grecourt pushed a commit to Captain1653/helidon that referenced this issue Jun 5, 2023
@Captain1653 @romain-grecourt
Add hamcrest-all to dependencies of eclipselink-maven-plugin (helidon…
28d7f36 
…-io#1749)
romain-grecourt added a commit that referenced this issue Jun 6, 2023
@Captain1653 @romain-grecourt
Use Hamcrest assertions instead of JUnit in integrations/cdi/jpa-cdi-…
1a2bf55 
… backport 2.x (#1749) (#5252)

* Use Hamcrest assertions instead of JUnit in  integrations/cdi/jpa-cdi - backport 2.x (#1749)

* Fix copyright headers

* Add hamcrest-all to dependencies of eclipselink-maven-plugin (#1749)

---------

Co-authored-by: Romain Grecourt <romain.grecourt@oracle.com>
@tomas-langer tomas-langer added help wanted Extra attention is needed testing 3.x Issues for 3.x version branch 4.x Version 4.x labels Sep 7, 2023
Captain1653 added a commit to Captain1653/helidon that referenced this issue Jun 13, 2024
@Captain1653
4.x: Use Hamcrest assertions instead of JUnit in common/buffers (heli…
4b913cc 
…don-io#1749)
@Captain1653 Captain1653 mentioned this issue Jun 13, 2024
Merged
barchetta pushed a commit that referenced this issue Jun 26, 2024
@Captain1653
4.x: Use Hamcrest assertions instead of JUnit in common/buffers (#1749)…
9de8334 
… (#8883)
Captain1653 added a commit to Captain1653/helidon that referenced this issue Jun 26, 2024
@Captain1653
4.x: Use Hamcrest assertions instead of JUnit in webclient/htt1 (heli…
4009c51 
…don-io#1749)
@Captain1653 Captain1653 mentioned this issue Jun 26, 2024
Merged
romain-grecourt pushed a commit that referenced this issue Jul 1, 2024
@Captain1653
4.x: Use Hamcrest assertions instead of JUnit in webclient/htt1 (#1749)…
966c7f3 
… (#8914)
Captain1653 added a commit to Captain1653/helidon that referenced this issue Jul 2, 2024
@Captain1653
4.x: Use Hamcrest assertions instead of JUnit in dbclient/mongodb (he…
2af6e0a 
…lidon-io#1749)
@Captain1653 Captain1653 mentioned this issue Jul 2, 2024
Merged
romain-grecourt pushed a commit that referenced this issue Jul 20, 2024
@Captain1653
4.x: Use Hamcrest assertions instead of JUnit in dbclient/mongodb (#1749
6cc3cce 
) (#8934)
@m0mus m0mus added this to Backlog Aug 12, 2024
@m0mus m0mus moved this to In Progress in Backlog Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielkec danielkec

Labels
2.x Issues for 2.x version branch 3.x Issues for 3.x version branch 4.x Version 4.x help wanted Extra attention is needed P4 testing
Projects
Backlog
Status: In Progress
Milestone
No milestone
Development

No branches or pull requests
5 participants
@danielkec @romain-grecourt @Captain1653 @m0mus @tomas-langer