Use Hamcrest assertions instead of JUnit in common/reactive (#1749) #4908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Captain1653
commented
Sep 17, 2022
| @@ -98,7 +99,7 @@ public void onComplete() { | |||
| } catch (InterruptedException e) { | |||
| executorService.shutdownNow(); | |||
| } | |||
| assertFalse(errorFound.isPresent(), () -> errorFound.get()); | |||
| assertThat(errorFound.orElse(""), errorFound.isPresent(), is(false)); | |||
There was a problem hiding this comment.
I don't like this approach with Optional, but if you need the error message...
There was a problem hiding this comment.
For Helidon 4 (main branch), we do have an optional matcher. For this version, we can keep this.
Alternative:
assertThat(errorFound, is(Optional.empty()));
|
/oca-checked |
|
/trigger |
tomas-langer
approved these changes
Sep 19, 2022
| @@ -98,7 +99,7 @@ public void onComplete() { | |||
| } catch (InterruptedException e) { | |||
| executorService.shutdownNow(); | |||
| } | |||
| assertFalse(errorFound.isPresent(), () -> errorFound.get()); | |||
| assertThat(errorFound.orElse(""), errorFound.isPresent(), is(false)); | |||
There was a problem hiding this comment.
For Helidon 4 (main branch), we do have an optional matcher. For this version, we can keep this.
Alternative:
assertThat(errorFound, is(Optional.empty()));
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1749
I'll do backport into helidon-2.x after merge.
I've already signed OCA. It's an automation problem.
I followed these instructions