Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MP Messaging hamcrestination #1765

Merged
merged 3 commits into from
May 13, 2020
Merged

MP Messaging hamcrestination #1765

merged 3 commits into from
May 13, 2020

Conversation

danielkec
Copy link
Contributor

As part of #1749

@danielkec danielkec requested review from tomas-langer and Verdent May 11, 2020 18:49
tomas-langer
tomas-langer approved these changes May 12, 2020
View reviewed changes
Copy link
Member

@tomas-langer tomas-langer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tomas-langer
tomas-langer requested changes May 12, 2020
View reviewed changes
Copy link
Member

@tomas-langer tomas-langer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most checks have an explicit matcher.
Using correct matcher makes failure output much easier to read.

E.g. instead of expected true but got false, you would get expected collection of size 1, but got ["a", "b"]

...c/test/java/io/helidon/microprofile/messaging/inner/subscriber/SubscriberPublToSubsBean.java Outdated Show resolved Hide resolved
...c/test/java/io/helidon/microprofile/messaging/inner/subscriber/SubscriberPublToSubsBean.java Outdated Show resolved Hide resolved
danielkec added 2 commits May 12, 2020 16:27
@danielkec
Cleanup
92e5542 
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec
Review issues
120fa6a
@danielkec danielkec requested a review from tomas-langer May 13, 2020 11:05
tomas-langer
tomas-langer approved these changes May 13, 2020
View reviewed changes
Copy link
Member

@tomas-langer tomas-langer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielkec
Copy link
Contributor Author

/trigger

@danielkec danielkec merged commit 7889194 into helidon-io:master May 13, 2020
@Captain1653 Captain1653 mentioned this pull request Sep 17, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomas-langer tomas-langer tomas-langer approved these changes

@romain-grecourt romain-grecourt romain-grecourt left review comments

@Verdent Verdent Awaiting requested review from Verdent

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielkec @romain-grecourt @tomas-langer