-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Helidon Metrics integration with OCI #5829
Merged
klustria
merged 4 commits into
helidon-io:helidon-3.x
from
klustria:3137-helidon_metrics_to_oci_integration-3.x
Jan 13, 2023
Merged
Add Helidon Metrics integration with OCI #5829
klustria
merged 4 commits into
helidon-io:helidon-3.x
from
klustria:3137-helidon_metrics_to_oci_integration-3.x
Jan 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change includes the following: 1. Port of PR helidon-io#4003 that adds the Helidon Metrics to OCI integration 2. Port of PR helidon-io#4897 that fixes race condition in the unit test 3. Adjust code to deal with MP metrics API changes 4. Change endpoint to the ingestion endpoint when posting the metrics as this is not handled anymore by the OCI SDK integration due to changes in the OCI Java SDK v3. 5. Change MonitoringClient.class to Monitoring.class for mocking using Mockito in the unit test as the OCI Java SDK v3 converted some of the methods in MonitoringClient as Final making them difficult to mock. 6. Trim the OCI Metadata value which contains the metric description if the value exceeds 256 characters, otherwise it will fail. 7. OCI Monitoring service only allows a maximum of 50 metrics per posting, hence additional configuration parameters were added to control sending metrics in batches. The configuration parameters are: a. batchSize - Maximum no. of metrics to send in a batch. Defaults to 50 which is what OCI allows b. batchDelay - Interval between batch posting For example if there are 51 metrics and batchSize is set to 25 and batchDelay to 5 seconds, the Helidon metric integration module will divide the posting to 3 batches sending 25 metrics on the 1st and 2nd batches and 1 metric on the 3rd batch with 5 seconds interval between batch posting. 8. Refactor OciMetricsCdiExtension to add a new bean (OciMetricsBean) to handle the Observer method which will inject Monitoring. Previous code of OciMetricsCdiExtension cannot independently handle instantiation of Monitoring client via CDI. 9. Add unit tests to verify batch posting feature and the use of ingestion endpoint.
oracle-contributor-agreement
bot
added
the
OCA Verified
All contributors have signed the Oracle Contributor Agreement.
label
Jan 11, 2023
ljnelson
reviewed
Jan 11, 2023
...ns/oci/metrics/cdi/src/main/java/io/helidon/integrations/oci/metrics/cdi/OciMetricsBean.java
Outdated
Show resolved
Hide resolved
…r method so it can be injected
…_metrics_to_oci_integration-3.x
tjquinno
requested changes
Jan 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few notes.
...oci/metrics/metrics/src/main/java/io/helidon/integrations/oci/metrics/OciMetricsSupport.java
Outdated
Show resolved
Hide resolved
...oci/metrics/metrics/src/main/java/io/helidon/integrations/oci/metrics/OciMetricsSupport.java
Show resolved
Hide resolved
...oci/metrics/metrics/src/main/java/io/helidon/integrations/oci/metrics/OciMetricsSupport.java
Outdated
Show resolved
Hide resolved
...oci/metrics/metrics/src/main/java/io/helidon/integrations/oci/metrics/OciMetricsSupport.java
Outdated
Show resolved
Hide resolved
...oci/metrics/metrics/src/main/java/io/helidon/integrations/oci/metrics/OciMetricsSupport.java
Show resolved
Hide resolved
…use of stream in list, execute rule.onNewWebserver only if enabled, add default value on @ConfigProperty and validate builder methods' parameters are not null
tjquinno
approved these changes
Jan 12, 2023
klustria
added a commit
to klustria/helidon
that referenced
this pull request
Jan 23, 2023
The change includes the following: 1. Port of v3 PR helidon-io#5829 that includes additional changes and fixes. 2. Changes related to OciMetricsSupport use of Nima instead of SE Webserver dependency.
klustria
added a commit
that referenced
this pull request
Jan 24, 2023
* Add Helidon Metrics integration with OCI The change includes the following: 1. Port of v3 PR #5829 that includes additional changes and fixes. 2. Changes related to OciMetricsSupport use of Nima instead of SE Webserver dependency. 3. Fix pipeline error due to javadoc link that cannot be referenced
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3.x
Issues for 3.x version branch
OCA Verified
All contributors have signed the Oracle Contributor Agreement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change includes the following: