Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helidon metrics to oci integration #5945

Merged

Conversation

klustria
Copy link
Member

@klustria klustria commented Jan 23, 2023

The change includes the following:

  1. Port of v3 PR Add Helidon Metrics integration with OCI #5829 that includes additional changes and fixes.
  2. Changes related to OciMetricsSupport use of Nima instead of SE Webserver dependency.

The change includes the following:
1. Port of v3 PR helidon-io#5829 that includes additional changes and fixes.
2. Changes related to OciMetricsSupport use of Nima instead of SE Webserver dependency.
@klustria klustria requested a review from tjquinno January 23, 2023 20:49
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jan 23, 2023
@klustria klustria changed the title 3137 helidon metrics to oci integration main helidon metrics to oci integration Jan 23, 2023
Copy link
Member

@tjquinno tjquinno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One possible slight optimization suggestion.

@klustria klustria merged commit 14e28ee into helidon-io:main Jan 24, 2023
@klustria
Copy link
Member Author

#5945 is completed hence closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants