Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x] - MP Telemetry Documentation #6772

Merged
merged 15 commits into from
Jun 12, 2023

Conversation

dalexandrov
Copy link
Contributor

Resolves #5817 for documentation

@dalexandrov dalexandrov added docs tracing 3.x Issues for 3.x version branch telemetry labels May 4, 2023
@dalexandrov dalexandrov added this to the 4.0.0-M1 milestone May 4, 2023
@dalexandrov dalexandrov self-assigned this May 4, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label May 4, 2023
@dalexandrov dalexandrov marked this pull request as draft May 4, 2023 15:11
@dalexandrov dalexandrov force-pushed the 5817_MP_Telemetry_Doc branch from 8ac282d to 80d7916 Compare May 12, 2023 11:47
@dalexandrov dalexandrov marked this pull request as ready for review May 15, 2023 11:05
@barchetta barchetta added 4.x Version 4.x and removed 3.x Issues for 3.x version branch labels May 18, 2023
@ljamen ljamen self-requested a review May 24, 2023 19:51
Copy link
Contributor

@ljamen ljamen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small updates.

examples/microprofile/telemetry/greeting/README.md Outdated Show resolved Hide resolved
jaegertracing/all-in-one:1.41
```

Run the Secondary service. Go to `secondary` folder and run:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

location of folder?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let it be project :)

examples/microprofile/telemetry/greeting/README.md Outdated Show resolved Hide resolved
docs/mp/telemetry.adoc Outdated Show resolved Hide resolved
@dalexandrov dalexandrov requested a review from ljamen June 7, 2023 14:15
Copy link
Contributor

@ljamen ljamen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very small updates to doc. Please check the copyright info for each file. It may cause your builds to break.

docs/mp/telemetry.adoc Outdated Show resolved Hide resolved
docs/mp/telemetry.adoc Outdated Show resolved Hide resolved
docs/mp/telemetry.adoc Outdated Show resolved Hide resolved
docs/mp/telemetry.adoc Outdated Show resolved Hide resolved
docs/mp/telemetry.adoc Outdated Show resolved Hide resolved
docs/mp/telemetry.adoc Outdated Show resolved Hide resolved
docs/mp/telemetry.adoc Outdated Show resolved Hide resolved
@dalexandrov dalexandrov force-pushed the 5817_MP_Telemetry_Doc branch from 62db4dd to 4c262ff Compare June 7, 2023 14:46
@dalexandrov dalexandrov requested a review from ljamen June 7, 2023 14:58
Copy link
Contributor

@ljamen ljamen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks

@dalexandrov dalexandrov requested a review from tjquinno June 7, 2023 15:21
@ljamen ljamen self-requested a review June 12, 2023 16:09
@ljamen ljamen merged commit 261d08c into helidon-io:main Jun 12, 2023
@dalexandrov dalexandrov deleted the 5817_MP_Telemetry_Doc branch June 27, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x Version 4.x docs OCA Verified All contributors have signed the Oracle Contributor Agreement. telemetry tracing
Projects
Archived in project
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants