Generalize OCI metrics support; add tests for the generalization #8419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tim Quinn <tim.quinn@oracle.com>
oracle-contributor-agreement
bot
added
the
OCA Verified
tjquinno
requested review from
klustria,
barchetta,
ljnelson and
arjav-desai
klustria
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #8429
This PR slightly generalizes how the OCI metrics integration is set up.
Most of the work continues to be done in
OciMetricsBeanbut this class can now be extended in two ways:OciMetricsSupport.Builderis preparedOciMetricsSupportinstanceThe PR includes an example customization of the bean as well as tests using the customization to make sure the customized bean (designated as a CDI
@Alternateand with a more urgent@Prioritythan the normal bean implementation) is used.As noted in the original bean class comments, it's essential that the observer method in the bean run after an observer method in the Helidon MP metrics extension. The PR adds a test using reflection to verify this requirement.
Documentation
No impact.
This generalization is intended for use by library authors familiar with Helidon's workings as opposed to application developers. As a result, beyond the JavaDoc in the PR there is no need to update the user documentation.