Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x] Generalize the creation of the OciMetricsSupport instance from CDI #8431

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

tjquinno
Copy link
Member

Description

Resolves #8430

This is a forward-port of PR #8419. See that PR for notes.

Documentation

No impact.

Signed-off-by: Tim Quinn <tim.quinn@oracle.com>
@tjquinno tjquinno self-assigned this Feb 27, 2024
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Feb 27, 2024
@tjquinno tjquinno changed the title Generalize the creation of the OciMetricsSupport instance from CDI Generalize the creation of the OciMetricsSupport instance from CDI Feb 27, 2024
@tjquinno tjquinno changed the title Generalize the creation of the OciMetricsSupport instance from CDI [4.x] Generalize the creation of the OciMetricsSupport instance from CDI Feb 27, 2024
Copy link
Member

@klustria klustria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tjquinno tjquinno merged commit 63971be into helidon-io:main Feb 28, 2024
12 checks passed
@tjquinno tjquinno deleted the 4.x-oci-metrics-genl branch February 28, 2024 17:03
hrstoyanov pushed a commit to hrstoyanov/helidon that referenced this pull request Mar 12, 2024
hrstoyanov pushed a commit to hrstoyanov/helidon that referenced this pull request Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
2 participants