4.x: Fix problem where throwing an Error would close connection but send keep-alive #9014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The HTTP/1.1 connection now correctly sends Connection: close header on throwables that cause the connection to be closed.
oracle-contributor-agreement
bot
added
the
OCA Verified
romain-grecourt
approved these changes
Jul 19, 2024
spericas
approved these changes
Jul 19, 2024
barchetta
pushed a commit
to barchetta/helidon
that referenced
this pull request
Jul 19, 2024
…end keep-alive (helidon-io#9014) * Fix wrong keep alive when error happens. * Error handlers now correctly handle Throwable and not just Exception. The HTTP/1.1 connection now correctly sends Connection: close header on throwables that cause the connection to be closed.
barchetta
added a commit
that referenced
this pull request
Jul 19, 2024
…end keep-alive (#9014) (#9016) * Fix wrong keep alive when error happens. * Error handlers now correctly handle Throwable and not just Exception. The HTTP/1.1 connection now correctly sends Connection: close header on throwables that cause the connection to be closed. Co-authored-by: Tomas Langer <tomas.langer@oracle.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #9013
ErrorHandlersnow handleThrowableinstead of justException- this is the signature ofErrorHandlerand also covers user specific Error classesHttp1Connectionnow sendsConnection: closeif an exception is caught outside of the handle loop, as the connection is always terminated after thisThe second case cannot have an integration test easily written, as it is specifically for handling unexpected exceptions outside of routing.